-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to the new API for marking as required the region
field of the Cloud Function resource
#576
Switch to the new API for marking as required the region
field of the Cloud Function resource
#576
Conversation
Signed-off-by: trampfox <trampfox@gmail.com>
bfead46
to
34ea968
Compare
/test-examples="examples/cloudfunctions/v1beta2/function.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @trampfox, thanks for the fix. The change looks good to me, but it would be good if you add the manual test results to the description before continuing. The resource's uptest skipped because it contains manual-intervention. So, can you test manually and verify that the problem is gone
Chiming in to provide moral support on merging this one. |
Hi @clarkritchie, thank you for your interest. Are you willing to test the resource manually? |
@turkenf Sure thing, apologies that I missed your comment. |
@clarkritchie, could you please test with the following:
|
@turkenf I can confirm CloudFunction creation is working when pointing to |
Awesome, thank you @chakrii! |
@chakrii, thank you for sharing results,I couldn't quite understand from the screenshots you shared, does the issue go away even if the provider is not healthy? Edit: Ahh, I just saw that the config package is unhealthy |
@turkenf Config package is unhealthy but at least the CloudFunction got created and no longer seeing issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience and interaction here, folks. LGTM.
Description of your changes
This PR switches to the new
config.Resource.MarkAsRequired
to mark as required theregion
field of the Cloud Function resource.Fixes #575
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested