Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test bigquery & dataflow group with uptest #58

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Test bigquery & dataflow group with uptest #58

merged 2 commits into from
Nov 22, 2022

Conversation

ulucinar
Copy link
Contributor

@ulucinar ulucinar commented Nov 21, 2022 •
edited
Loading

Description of your changes

This PR attempts to test the bigquery & dataflow groups with the uptest tooling.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

The results are recorded in PR #56.

@ulucinar ulucinar marked this pull request as draft November 21, 2022 13:17
@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/connection.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/datatransferconfig.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/dataset.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/datasetaccess.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/reservation.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/reservationassignment.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/routine.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/table.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/datatransferconfig.yaml"

@ulucinar
Copy link
Contributor Author

ulucinar commented Nov 21, 2022 •
edited
Loading

We had to enable the following APIs for the GCP project to get the tests working:

  • bigquerydatatransfer.googleapis.com
  • dataflow.googleapis.com
  • bigqueryreservation.googleapis.com
  • iam.googleapis.com (was already enabled for the project)
  • bigqueryconnection.googleapis.com

We also had to assign the BigQuery Admin role to the IAM service account used with uptest.

@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/reservation.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/reservationassignment.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/dataset.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/connection.yaml"

@ulucinar
Fix examples/bigquery/reservationassignment.yaml
89e0b9b 
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@turkenf
Copy link
Collaborator

turkenf commented Nov 21, 2022

/test-examples="examples/bigquery/reservationassignment.yaml"

@ulucinar
Copy link
Contributor Author

/test-examples="examples/bigquery/datasetaccess.yaml"

@ulucinar ulucinar marked this pull request as ready for review November 21, 2022 21:44
@ulucinar ulucinar changed the title Commit for testing bigquery & dataflow group with uptest Test bigquery & dataflow group with uptest Nov 22, 2022
@ulucinar
Copy link
Contributor Author

Hi @turkenf,
After fixing the permissions issue, the datasourceaccess has succeeded. The old status checks have disappeared with the new commit but there is no need to rerun the tests as currently the only changed example manifest is the reservationassignment manifest.

@turkenf
Copy link
Collaborator

turkenf commented Nov 22, 2022

/test-examples="examples/bigquery/dataset.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 22, 2022

/test-examples="examples/bigquery/connection.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Nov 22, 2022

/test-examples="examples/bigquery/connection.yaml"

turkenh
turkenh approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@ulucinar
Copy link
Contributor Author

ulucinar commented Nov 22, 2022 •
edited
Loading

Thank you @turkenf! And thank you @turkenh for the review.

@ulucinar ulucinar merged commit f903f5c into crossplane-contrib:main Nov 22, 2022
@ulucinar ulucinar deleted the bigquery-uptest branch November 22, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turkenh turkenh turkenh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulucinar @turkenf @turkenh