Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Terraform Provider to v5.39.0 #593

Conversation

mauricewittek
Copy link
Contributor

@mauricewittek mauricewittek commented Jul 29, 2024

Description of your changes

This PR upgrades the Terraform provider version to v5.39.0

Fixes #577
Fixes #561

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Manually

NAME                                          SYNCED   READY   EXTERNAL-NAME   AGE
cluster.alloydb.gcp.upbound.io/alloydb-test   True     True    alloydb-test    7m7s
  • examples/bigquery/v1beta1/connection.yaml => Uptest fails due to an update loop on the dependent DatabaseInstance resource, the Connection resource tested successfully:
NAME                                                    SYNCED   READY   EXTERNAL-NAME
  AGE
connection.bigquery.gcp.upbound.io/connection-fttest5   True     True    projects/official-provider-testing/locations/US/connections/6b8b0517-bffd-42b7-9811-2a415cb97c71
  41m
  • examples/bigquery/v1beta1/table.yaml => Uptest failed due to id change
NAME                                    SYNCED   READY   EXTERNAL-NAME   AGE
table.bigquery.gcp.upbound.io/default   True     True    default         32m

Uptest

Signed-off-by: Maurice Wittek <maurice.wittek@grafana.com>
Signed-off-by: Maurice Wittek <maurice.wittek@grafana.com>
@mauricewittek mauricewittek changed the title Mwittek/update terraform provider 5 38 Update Terraform Provider to v5.38.0 Jul 29, 2024
@turkenf
Copy link
Collaborator

turkenf commented Jul 30, 2024

Many thanks for your effort, @mauricewittek; your changes look fine. Since we need to progress faster in this PR, we will take over the PR to support the newly added fields in older versions and to update the provider to the latest version.

We welcome you to follow this PR and let us know if you have any suggestions 🙏

…n make generate

Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator

turkenf commented Jul 30, 2024

/test-examples="examples/networkconnectivity/v1beta1/hub.yaml"

@mergenci mergenci changed the title Update Terraform Provider to v5.38.0 Update Terraform Provider to v5.39.0 Jul 30, 2024
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator

turkenf commented Jul 30, 2024

/test-examples="examples/alloydb/v1beta1/cluster.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jul 30, 2024

/test-examples="examples/artifact/v1beta1/registryrepository.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jul 30, 2024

/test-examples="examples/bigquery/v1beta1/connection.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jul 30, 2024

/test-examples="examples/bigquery/v1beta1/dataset.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jul 30, 2024

/test-examples="examples/bigquery/v1beta1/table.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jul 30, 2024

/test-examples="examples/bigtable/v1beta1/instance.yaml"

@turkenf turkenf marked this pull request as draft July 30, 2024 20:46
mergenci added 3 commits July 31, 2024 04:30
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
@turkenf
Copy link
Collaborator

turkenf commented Jul 31, 2024

/test-examples="examples/bigquery/v1beta1/dataset.yaml"

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
@turkenf
Copy link
Collaborator

turkenf commented Jul 31, 2024

/test-examples="examples/bigquery/v1beta1/dataset.yaml"

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
@mergenci
Copy link
Collaborator

/test-examples="examples/bigquery/v1beta1/dataset.yaml"

1 similar comment
@turkenf
Copy link
Collaborator

turkenf commented Jul 31, 2024

/test-examples="examples/bigquery/v1beta1/dataset.yaml"

Excluding Datastream and Container services.

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/bigquery/v1beta1/dataset.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/bigquery/v1beta1/table.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/bigtable/v1beta1/instance.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/compute/v1beta1/firewall.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/compute/v1beta2/router.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/container/v1beta2/cluster.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/dns/v1beta2/policy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/spanner/v1beta2/database.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/storage/v1beta2/bucket.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/alloydb/v1beta1/cluster.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/sql/v1beta1/databaseinstance.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/sql/v1beta1/instance.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/bigtable/v1beta1/appprofile.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/compute/v1beta1/backendservice.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/compute/v1beta1/instance.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/datafusion/v1beta1/instance.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/gke/v1beta1/backupbackupplan.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/pubsub/v1beta1/topic.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/storage/v1beta1/bucket.yaml "

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/datafusion/v1beta1/instance.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/container/v1beta1/nodepool.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/compute/v1beta2/instancefromtemplate.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Aug 5, 2024

/test-examples="examples/cloudplatform/v1beta2/serviceaccountiammember.yaml"

@turkenf turkenf marked this pull request as ready for review August 5, 2024 21:40
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator

turkenf commented Aug 6, 2024

/test-examples="examples/alloydb/v1beta1/cluster.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your efforts @mauricewittek, @mergenci 🙌 LGTM.

Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for joining the roller coaster ride @turkenf 😅 Special thanks to @mauricewittek for the ticket 🙂

@turkenf turkenf merged commit 3efed14 into crossplane-contrib:main Aug 6, 2024
10 checks passed
@turkenf turkenf mentioned this pull request Sep 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants