-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Terraform Provider to v5.39.0 #593
Update Terraform Provider to v5.39.0 #593
Conversation
Signed-off-by: Maurice Wittek <maurice.wittek@grafana.com>
Signed-off-by: Maurice Wittek <maurice.wittek@grafana.com>
Many thanks for your effort, @mauricewittek; your changes look fine. Since we need to progress faster in this PR, we will take over the PR to support the newly added fields in older versions and to update the provider to the latest version. We welcome you to follow this PR and let us know if you have any suggestions 🙏 |
…n make generate Signed-off-by: Fatih Türken <turkenf@gmail.com>
/test-examples="examples/networkconnectivity/v1beta1/hub.yaml" |
Signed-off-by: Fatih Türken <turkenf@gmail.com>
/test-examples="examples/alloydb/v1beta1/cluster.yaml" |
/test-examples="examples/artifact/v1beta1/registryrepository.yaml" |
/test-examples="examples/bigquery/v1beta1/connection.yaml" |
/test-examples="examples/bigquery/v1beta1/dataset.yaml" |
/test-examples="examples/bigquery/v1beta1/table.yaml" |
/test-examples="examples/bigtable/v1beta1/instance.yaml" |
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
/test-examples="examples/bigquery/v1beta1/dataset.yaml" |
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
/test-examples="examples/bigquery/v1beta1/dataset.yaml" |
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
/test-examples="examples/bigquery/v1beta1/dataset.yaml" |
1 similar comment
/test-examples="examples/bigquery/v1beta1/dataset.yaml" |
Excluding Datastream and Container services. Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
/test-examples="examples/bigquery/v1beta1/dataset.yaml" |
/test-examples="examples/bigquery/v1beta1/table.yaml" |
/test-examples="examples/bigtable/v1beta1/instance.yaml" |
/test-examples="examples/compute/v1beta1/firewall.yaml" |
/test-examples="examples/compute/v1beta2/router.yaml" |
/test-examples="examples/container/v1beta2/cluster.yaml" |
/test-examples="examples/dns/v1beta2/policy.yaml" |
/test-examples="examples/spanner/v1beta2/database.yaml" |
/test-examples="examples/storage/v1beta2/bucket.yaml" |
/test-examples="examples/alloydb/v1beta1/cluster.yaml" |
/test-examples="examples/sql/v1beta1/databaseinstance.yaml" |
/test-examples="examples/sql/v1beta1/instance.yaml" |
/test-examples="examples/bigtable/v1beta1/appprofile.yaml" |
/test-examples="examples/compute/v1beta1/backendservice.yaml" |
/test-examples="examples/compute/v1beta1/instance.yaml" |
/test-examples="examples/datafusion/v1beta1/instance.yaml" |
/test-examples="examples/gke/v1beta1/backupbackupplan.yaml" |
/test-examples="examples/pubsub/v1beta1/topic.yaml" |
/test-examples="examples/storage/v1beta1/bucket.yaml " |
/test-examples="examples/datafusion/v1beta1/instance.yaml" |
/test-examples="examples/container/v1beta1/nodepool.yaml" |
/test-examples="examples/compute/v1beta2/instancefromtemplate.yaml" |
/test-examples="examples/cloudplatform/v1beta2/serviceaccountiammember.yaml" |
Signed-off-by: Fatih Türken <turkenf@gmail.com>
/test-examples="examples/alloydb/v1beta1/cluster.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your efforts @mauricewittek, @mergenci 🙌 LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for joining the roller coaster ride @turkenf 😅 Special thanks to @mauricewittek for the ticket 🙂
Description of your changes
This PR upgrades the Terraform provider version to
v5.39.0
Fixes #577
Fixes #561
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Manually
examples/alloydb/v1beta1/cluster.yaml
and Uptest:https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10266597573examples/bigquery/v1beta1/connection.yaml
=> Uptest fails due to an update loop on the dependent DatabaseInstance resource, the Connection resource tested successfully:examples/bigquery/v1beta1/table.yaml
=> Uptest failed due to id changeUptest
examples/artifact/v1beta1/registryrepository.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10251167949examples/bigquery/v1beta1/dataset.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10251169622examples/bigtable/v1beta1/appprofile.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10254413056examples/bigtable/v1beta1/instance.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10251172457examples/compute/v1beta1/backendservice.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10254428661examples/compute/v1beta1/firewall.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10253797284examples/compute/v1beta1/instance.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10254442870examples/compute/v1beta2/router.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10253799068examples/container/v1beta1/nodepool.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10255240004examples/container/v1beta2/cluster.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10253802521examples/datafusion/v1beta1/instance.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10255070133examples/dns/v1beta2/policy.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10253808520examples/gke/v1beta1/backupbackupplan.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10254515114examples/networkconnectivity/v1beta1/hub.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10251165472examples/pubsub/v1beta1/topic.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10254532142examples/spanner/v1beta2/database.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10253810349examples/sql/v1beta1/instance.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10254010444examples/storage/v1beta1/bucket.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10254537156examples/storage/v1beta2/bucket.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10253812629examples/compute/v1beta2/instancefromtemplate.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10256057021examples/cloudplatform/v1beta2/serviceaccountiammember.yaml
=> https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10256058380