Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Terraform provider plugin version to v4.48.0 #63

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

ulucinar
Copy link
Contributor

@ulucinar ulucinar commented Nov 28, 2022

Description of your changes

Fixes #55

Bumps Terraform provider version to v4.44.1.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Resource sets tested here:
#137

@ulucinar ulucinar marked this pull request as draft November 28, 2022 12:14
@ulucinar ulucinar force-pushed the tf-provider-4.44.1 branch 2 times, most recently from 2d477ea to fedca12 Compare December 22, 2022 07:34
@ulucinar ulucinar changed the title Bump Terraform provider plugin version to v4.44.1 Bump Terraform provider plugin version to v4.47.0 Dec 22, 2022
@ulucinar ulucinar force-pushed the tf-provider-4.44.1 branch from fedca12 to c7e7d53 Compare January 2, 2023 20:20
@ulucinar ulucinar changed the title Bump Terraform provider plugin version to v4.47.0 Bump Terraform provider plugin version to v4.48.0 Jan 17, 2023
@ulucinar
Copy link
Contributor Author

The only Terraform schema change reported is as follows between the versions 4.22.0 and 4.48.0:

google_cloudbuild_trigger:1-2

@ulucinar
Copy link
Contributor Author

ulucinar commented Jan 17, 2023

And the breaking API changes reported for the generated CRDs:

cloudrun.gcp.upbound.io_services.yaml
compute.gcp.upbound.io_networkendpoints.yaml
container.gcp.upbound.io_clusters.yaml
container.gcp.upbound.io_nodepools.yaml
dns.gcp.upbound.io_recordsets.yaml

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
- Optional field removal is now considered as a breaking API change

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
- During the native provider bump from 4.22.0->4.48.0,
  crddiff detected the ref fields were removed. And
  the reason is the referenced resource (google_secret_manager_secret)
  was removed from the example in the Terraform registry.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar ulucinar merged commit f33f8ed into crossplane-contrib:main Jan 20, 2023
@ulucinar ulucinar deleted the tf-provider-4.44.1 branch January 20, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade underlying GCP terraform provider
3 participants