-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dataplex): add aspect_type resource #662
feat(dataplex): add aspect_type resource #662
Conversation
/test-examples="examples/dataplex/v1beta1/aspecttype.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @nilan3, I left a comment about external-name configuration for you to consider.
e9540d9
to
1a94808
Compare
/test-examples="examples/dataplex/v1beta1/aspecttype.yaml" |
/test-examples="examples/dataplex/v1beta1/aspecttype.yaml" |
Signed-off-by: nilan3 <nilanthanb1994@gmail.com>
Signed-off-by: nilan3 <nilanthanb1994@gmail.com>
Signed-off-by: nilan3 <nilanthanb1994@gmail.com>
Signed-off-by: nilan3 <nilanthanb1994@gmail.com>
Signed-off-by: Fatih Türken <turkenf@gmail.com>
8161138
to
c5495a6
Compare
/test-examples="examples/dataplex/v1beta1/aspecttype.yaml" https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/12181104764 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your effort @nilan3, I had to push a commit to include this PR in the release we will be making today 🙂
Description of your changes
Add resources for the following terraform resources:
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
UPTEST_EXAMPLE_LIST="examples/dataplex/v1beta1/aspecttype.yaml"