Update golangci-lint to 1.61.0 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a problem on macOS (arm64) where lint fails with error
message from typecheck.
Example:
14:02:02 [ .. ] golangci-lint
apis/accesscontextmanager/v1beta1/zz_accesslevel_terraformed.go:87:79: tr.GetName undefined (type *AccessLevel has no field or method GetName) (typecheck)
return nil, errors.Wrapf(err, "cannot get parameters for resource '%q'", tr.GetName())
^
For more information see https://golangci-lint.run/welcome/faq/#why-do-you-have-typecheck-errors
Signed-off-by: Rickard von Essen <rickard.von.essen@gmail.com>
rickard-von-essen
force-pushed
the
lint-1.61.0
branch
from
db61f38
to
3c351ba
Compare
3 tasks
jbw976
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
This looks good to me @rickard-von-essen, I could actually use this myself in https://github.com/jbw976/conformance/tree/modernize 😉
Out of curiosity, did you see anything in the release notes, or an issue specifically talking about the mac typecheck bug? I didn't see it when quickly looking through the link you provided...
Not really, but the FAQ had as first point of resolving these issues "update to latest", and that solved it for me. 😜 |
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a problem on macOS (arm64) where lint fails with error message from typecheck.
Example:
For more information see https://golangci-lint.run/welcome/faq/#why-do-you-have-typecheck-errors