Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespaced resources with externalName fails to update #245

Closed
ctrox opened this issue Feb 25, 2021 · 1 comment
Closed

Namespaced resources with externalName fails to update #245

ctrox opened this issue Feb 25, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@ctrox
Copy link

ctrox commented Feb 25, 2021

What happened?

I'm using crossplane-runtime with a namespaced CR wanted to use the externalName feature.

How can we reproduce it?

Use a namespaced CR and return ExternalNameAssigned = true in Create. This results in the following error:

2021-02-24T16:59:21.926+0100    DEBUG   account_test    Cannot update managed resource  {"controller": "managed/account.example.org", "request": "default/test-acc-b5f78", "uid": "cb3d3cd8-90ca-4d61-a394-b04bc932e1fb", "version": "94", "external-name": "", "error": "Account.example.org \"test-acc-b5f78\" not found", "requeue-after": "2021-02-24T16:59:26.926+0100"}

The fix is quite simple, I will submit a PR shortly.

What environment did it happen in?

Crossplane-runtime version: v0.12.0 and also on master
@ctrox ctrox added the bug Something isn't working label Feb 25, 2021
ctrox added a commit to ctrox/crossplane-runtime that referenced this issue Feb 25, 2021
@ctrox
Set namespace when looking up resource with externalName
f4d5fc3 
Fixes crossplane#245
ctrox added a commit to ctrox/crossplane-runtime that referenced this issue Feb 25, 2021
@ctrox
Set namespace when looking up resource with externalName
bc257f0 
Fixes crossplane#245

Signed-off-by: Cyrill Troxler <cyrill@nine.ch>
@ctrox ctrox mentioned this issue Feb 25, 2021
Closed
2 tasks
@ctrox
Copy link
Author

ctrox commented Mar 9, 2021

This turned out not to be a bug, I addressed the wider issue here: #251

@ctrox ctrox closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set namespace when looking up resource with externalName ctrox/crossplane-runtime
1 participant
@ctrox