Add package doc for packages that currently lack it. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nic Cope <negz@rk0n.org>
|
hmm I thought rerunning CI would fix this, but it looks like it failed again 🤔 |
|
Master is actually super broken at the moment. 🤔 I have no idea how #106 made it past CI, because it does not build. |
...and the stuttering name linter warnings created by said fix. Signed-off-by: Nic Cope <negz@rk0n.org>
|
@hasheddan PTAL - I've pushed a commit that fixes the package names. |
|
|
hasheddan
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Checklist
I have:
make reviewableto ensure this PR is ready for review.clusterrole.yamlto include any new types.