Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Applicator interface #125

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Add Applicator interface #125

merged 1 commit into from
Mar 4, 2020

Conversation

hasheddan
Copy link
Member

Signed-off-by: hasheddan georgedanielmangum@gmail.com

Description of your changes

Adds Applicator interface for easy dependency injection in testing. Example of usage here: https://github.com/crossplane/stack-oam-kubernetes-remote/pull/1/files#diff-9fcf6c6c0f2cbfcb9d516f226d575681R167

Checklist

I have:

  • Run make reviewable to ensure this PR is ready for review.
  • Ensured this PR contains a neat, self documenting set of commits.
  • Updated any relevant documentation, examples, or release notes.
  • Updated the RBAC permissions in clusterrole.yaml to include any new types.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan hasheddan requested a review from negz March 4, 2020 01:25
@negz negz merged commit c7524ab into crossplane:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants