AddOwnerRef should update

[muvaf]

Signed-off-by: Muvaffak Onus onus.muvaffak@gmail.com

Description of your changes

AddOwnerReference should always set the owner ref array to be able to modify the existing reference. Otherwise it never updates the existing owner ref.

Checklist

I have:

• Run make reviewable to ensure this PR is ready for review.
• Ensured this PR contains a neat, self documenting set of commits.
• Updated any relevant documentation, examples, or release notes.
• Updated the RBAC permissions in clusterrole.yaml to include any new types.

[hasheddan]

LGTM!

[negz]

Are you sure this is necessary? Typically I'd expect this to work per https://play.golang.org/p/KXo6vizZol2.

[muvaf]

Typically I'd expect this to work per https://play.golang.org/p/KXo6vizZol2.

I'm not able to access this as Go playground seems to be down.

Are you sure this is necessary?

Since GetOwnerReferences() []OwnerReference returns a copy of the owner references refs[i] = ref does pretty much nothing. I've run into this in an edge case where the object was owner but not controller and the owner ref didn't get updated because set never called. It'd be more correct if we actually updated the owner ref if it already exists or skip the case where it already exists altogether.

[negz]

Since GetOwnerReferences() []OwnerReference returns a copy of the owner references refs[i] = ref does pretty much nothing.

I suspect this might only be the case for *unstructured.Unstructured. Types that embed metav1.ObjectMeta just return the underlying struct, which is probably why we haven't noticed this until now. Either way, it doesn't seem safe to assume that the underlying struct is being returned and can be modified in place.