Remove support for resource claims and classes #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
added
release/breaking-api-change
See crossplane/crossplane#1670 for context. Signed-off-by: Nic Cope <negz@rk0n.org>
hasheddan
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
This LGTM! I wonder if we should also consider removing target-related things here and KA in crossplane while we are at it. Also just a note for anyone else following along that this will require large updates in each provider for them to be compatible with Crossplane v0.13
2 tasks
muvaf
approved these changes
Sep 21, 2020
|
I'm feeling pretty comfortable with this change having tested it with a branch of provider-gcp. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #179
Updates crossplane/crossplane#1670
See crossplane/crossplane#1670 for context.
Checklist
I have:
make reviewableto ensure this PR is ready for review.clusterrole.yamlto include any new types.