Plumb up reconciler contexts #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the Reconcile method started including a context in controller-runtime v0.8.0, but it was never plumbed up. If I follow the contexts correctly the one passed to Reconcile can be traced back to the one passed to mgr.Start, which is typically a context that is cancelled on SIGTERM or SIGINT. Signed-off-by: Nic Cope <negz@rk0n.org>
hasheddan
approved these changes
Oct 14, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I believe the Reconcile method started including a context in controller-runtime v0.8.0, but it was never plumbed up. If I follow the contexts correctly the one passed to Reconcile can be traced back to the one passed to mgr.Start, which is typically a context that is cancelled on SIGTERM or SIGINT.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I haven't manually tested this - we plumb the context in this fashion in our core reconcilers in crossplane/crossplane, so I expect the change to be low risk.