Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to 1.17 and k8s libraries to 1.23 #308

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Conversation

muvaf
Copy link
Member

@muvaf muvaf commented Jan 6, 2022

Description of your changes

go 1.17 introduced a change where all transitive dependency versions are added to go.mod in a separate section, see https://go.dev/doc/go1.17 for details.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

make reviewable test

Signed-off-by: Muvaffak Onus <me@muvaf.com>
Signed-off-by: Muvaffak Onus <me@muvaf.com>
Signed-off-by: Muvaffak Onus <me@muvaf.com>
@muvaf muvaf requested review from negz and hasheddan January 6, 2022 13:52
Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muvaf muvaf merged commit 428b7c3 into crossplane:master Jan 6, 2022
@muvaf muvaf deleted the upd-go branch January 6, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants