Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "IfNotPresent" to ResolvePolicy enum #334

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

sergenyalcin
Copy link
Member

@sergenyalcin sergenyalcin commented Jun 16, 2022

Description of your changes

Related #250 #328

This PR adds "IfNotPresent" option to ResolvePolicy kubebuilder enum. For details please see:
#328 (comment)
#328 (comment)

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

make reviewable

Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
@sergenyalcin sergenyalcin self-assigned this Jun 16, 2022
@sergenyalcin sergenyalcin requested review from muvaf and negz June 16, 2022 10:58
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergenyalcin !

@muvaf muvaf merged commit a520b60 into crossplane:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants