increase QPS and burst #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
avalanche123
force-pushed
the
increase-burst
branch
from
89401c6
to
b781506
Compare
|
@avalanche123 Could you fill out the "how has this code been tested" block, please. Specifically I'm curious whether it helped with crossplane/crossplane#3176 (review) (i.e. helped avoid client-side rate limiting there). |
Signed-off-by: Bulat Shakirzyanov <83289+avalanche123@users.noreply.github.com>
|
@negz done. I was able to install the official providers without hitting a context timeout or client side throttling. |
negz
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes burst as mentioned in crossplane/crossplane#3176
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested by installing official providers - all completed within the timeout without altering the
max-reconcile-rate