-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replicate OWNERS from c/c #374
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# This file controls automatic PR reviewer assignment. See the following docs: | ||
# | ||
# * https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners | ||
# * https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team | ||
# | ||
# The goal of this file is for most PRs to automatically and fairly have one | ||
# maintainer and two reviewers set as PR reviewers. All maintainers have | ||
# permission to approve and merge PRs, but reviewers do not. Most PRs should be | ||
# reviewed by members of the reviewers group before being passed to a maintainer | ||
# for final review. | ||
# | ||
# This in part depends on how the groups in this file are configured. | ||
# | ||
# @crossplane/steering-committee - Assigns 3 members. Admin perms to this repo. | ||
# @crossplane/crossplane-maintainers - Assigns 1 member. Maintain perms to this repo. | ||
# @crossplane/crossplane-reviewers - Assigns 2 members. Write perms to this repo. | ||
# | ||
# Where possible, prefer explicitly specifying a maintainer who is a subject | ||
# matter expert for a particular part of the codebase rather than using the | ||
# @crossplane/crossplane-maintainers group. | ||
# | ||
# See also OWNERS.md for governance details | ||
|
||
# Fallback owners | ||
* @crossplane/crossplane-maintainers @crossplane/crossplane-reviewers | ||
|
||
# Governance owners - steering committee | ||
/README.md @crossplane/steering-committee | ||
/OWNERS.md @crossplane/steering-committee | ||
/LICENSE @crossplane/steering-committee |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,32 @@ | ||
# OWNERS | ||
# Crossplane Maintainers | ||
|
||
This page lists all maintainers for **this** repository. Each repository in the [Crossplane | ||
organization](https://github.com/crossplane/) will list their repository maintainers in their own | ||
`OWNERS.md` file. | ||
This page lists all active maintainers and reviewers for **this** repository. | ||
Each repository in the [Crossplane organization](https://github.com/crossplane/) | ||
will list their repository maintainers and reviewers in their own `OWNERS.md` | ||
file. | ||
|
||
Please see [GOVERNANCE.md](https://github.com/crossplane/crossplane/blob/masterGOVERNANCE.md) | ||
for governance guidelines and responsibilities for maintainers, and reviewers. | ||
|
||
See [CODEOWNERS](CODEOWNERS) for automatic PR assignment. | ||
|
||
Please see the Crossplane | ||
[GOVERNANCE.md](https://github.com/crossplane/crossplane/blob/master/GOVERNANCE.md) for governance | ||
guidelines and responsibilities for the steering committee and maintainers. | ||
|
||
## Maintainers | ||
|
||
* Nic Cope <negz@upbound.io> ([negz](https://github.com/negz)) | ||
* Daniel Mangum <dan@upbound.io> ([hasheddan](https://github.com/hasheddan)) | ||
* Muvaffak Onuş <monus@upbound.io> ([muvaf](https://github.com/muvaf)) | ||
* Hasan Türken <hasan@upbound.io> ([turkenh](https://github.com/turkenh)) | ||
* Muvaffak Onus <monus@upbound.io> ([muvaf](https://github.com/muvaf)) | ||
* Hasan Turken <hasan@upbound.io> ([turkenh](https://github.com/turkenh)) | ||
|
||
## Reviewers | ||
|
||
* Bob Haddleton <bob.haddleton@nokia.com> ([bobh66](https://github.com/bobh66)) | ||
* Yury Tsarev <yury@upbound.io> ([ytsarev](https://github.com/ytsarev)) | ||
* Ezgi Demirel <ezgi@upbound.io> ([ezgidemirel](https://github.com/ezgidemirel)) | ||
* Max Blatt ([MisterMX](https://github.com/MisterMX)) | ||
* Philippe Scorsolini <philippe.scorsolini@upbound.io> ([phisco](https://github.com/phisco)) | ||
|
||
## Emeritus maintainers | ||
|
||
* Jared Watts <jared@upbound.io> ([jbw976](https://github.com/jbw976)) | ||
* Illya Chekrygin <illya.chekrygin@gmail.com> ([ichekrygin](https://github.com/ichekrygin)) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, interesting. I guess the file in this repo had correct characters but the file I copied from c/c did not. 🤔