fix: properly validate max index #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkenh
reviewed
Mar 8, 2023
phisco
force-pushed
the
dev/fix-max-index
branch
3 times, most recently
from
9cfa009
to
5ff9dd8
Compare
turkenh
reviewed
Mar 8, 2023
turkenh
reviewed
Mar 8, 2023
phisco
force-pushed
the
dev/fix-max-index
branch
2 times, most recently
from
4b252f4
to
1ee580d
Compare
turkenh
approved these changes
Mar 8, 2023
phisco
force-pushed
the
dev/fix-max-index
branch
from
1ee580d
to
d1d79c6
Compare
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
phisco
force-pushed
the
dev/fix-max-index
branch
from
d1d79c6
to
0aac4ba
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixing previously introduced variable mismatch in tests and refactoring code.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Added unit tests.