Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GitHub workflows and build submodule #400

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Bump GitHub workflows and build submodule #400

merged 3 commits into from
Mar 22, 2023

Conversation

negz
Copy link
Member

@negz negz commented Mar 18, 2023 •
edited
Loading

Description of your changes

Per #399 I found that this seems to fix make check-diff for #379. I haven't dug into why.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

I've just run #399 through CI and confirmed make check-diff works as expected.

@negz negz requested a review from ezgidemirel March 18, 2023 00:22
@negz negz mentioned this pull request Mar 18, 2023
Closed
ezgidemirel
ezgidemirel approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@ezgidemirel ezgidemirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton @negz!

@phisco
Copy link
Contributor

phisco commented Mar 21, 2023

@negz @ezgidemirel, the musttag linter is complaining about a lot of json tags missing, is it ok to add them or are you holding off for some reason?

negz and others added 3 commits March 22, 2023 12:42
@negz @turkenh
Bump versions in .github workflow
5d9c550 
Signed-off-by: Nic Cope <nicc@rk0n.org>
@negz @turkenh
Bump build
e8004ab 
Signed-off-by: Nic Cope <nicc@rk0n.org>
@turkenh
Add nolint directive for musttag on types used in unit tests
112e9ed 
Signed-off-by: Hasan Turken <turkenh@gmail.com>
@turkenh
Copy link
Member

turkenh commented Mar 22, 2023

@negz @ezgidemirel, the musttag linter is complaining about a lot of json tags missing, is it ok to add them or are you holding off for some reason?

Those types are fake/mock implementations used in unit tests, so I went ahead and added nolint directives instead.

@turkenh turkenh merged commit caacf09 into crossplane:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezgidemirel ezgidemirel ezgidemirel approved these changes

@turkenh turkenh turkenh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@negz @phisco @turkenh @ezgidemirel