Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module google.golang.org/protobuf to v1.31.0 #471

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 26, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
google.golang.org/protobuf require minor v1.30.0 -> v1.31.0

Release Notes

protocolbuffers/protobuf-go (google.golang.org/protobuf)

v1.31.0

Compare Source

Notable changes

New Features

  • CL/489316: types/dynamicpb: add NewTypes
    • Add a function to construct a dynamic type registry from a protoregistry.Files
  • CL/489615: encoding: add MarshalAppend to protojson and prototext

Minor performance improvements

  • CL/491596: encoding/protodelim: If UnmarshalFrom gets a bufio.Reader, try to reuse its buffer instead of creating a new one
  • CL/500695: proto: store the size of tag to avoid multiple calculations

Bug fixes

  • CL/497935: internal/order: fix sorting of synthetic oneofs to be deterministic
  • CL/505555: encoding/protodelim: fix handling of io.EOF

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested review from a team as code owners June 26, 2023 15:09
@renovate renovate bot requested a review from hasheddan June 26, 2023 15:09
@renovate renovate bot added the automated label Jun 26, 2023
@renovate renovate bot requested a review from lsviben June 26, 2023 15:09
@jbw976
Copy link
Member

jbw976 commented Jun 30, 2023

@phisco looks like the check-diff status check is failing here, due to a modified file apis/proto/v1alpha1/ess.pb.go.

When this happens on a renovate PR, is the typical procedure:

  • documented or written down somewhere?
  • to push a commit with the fix to source branch of this PR? OR
  • to close this PR and open a new one to do it manually along with the fix?

I may be able to take a stab at this one to learn the process better and help out in the future more, let me know what we typically do! 😉 🙇

@phisco
Copy link
Contributor

phisco commented Jun 30, 2023

@jbw976
It's not documented at the moment, it's a drawback of using the managed service from renovate, if we set it up to run on our infra / github action on a schedule, we could configure it to run make reviewable before committing, but it's happening mostly for this dependency and k8s related ones, so it's not such a big issue to justify the switch.
I usually do the following (using the gh cli):

$ gh pr checkout 471 # number of the PR at hand
...
$ make reviewable
...
$ git add .
...
$ git commit --gpg-sign --signoff -m "chore: regenerate files"
...
$ git push
...

@jbw976
Copy link
Member

jbw976 commented Jun 30, 2023

cool @phisco!! so essentially you are pushing to the branch for this PR then with your updates to make it green if i read that correctly 🟢

@jbw976 jbw976 self-assigned this Jun 30, 2023
Signed-off-by: Jared Watts <jbw976@gmail.com>
@renovate
Copy link
Contributor Author

renovate bot commented Jul 3, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@jbw976
Copy link
Member

jbw976 commented Jul 3, 2023

Thanks the for pointers @phisco, I followed those general steps and got this PR updated to pass the check-diff status now. Everything looks green now and nothing fishy looks altered! 💪

@jbw976 jbw976 merged commit e9ea002 into master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants