Add [Observe, Delete] as a supported management policy #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lsviben <sviben.lovro@gmail.com>
2 tasks
phisco
approved these changes
Nov 30, 2023
lsviben
added
backport release-1.12
backport release-1.13
backport release-1.14
and removed
backport release-1.12
backport release-1.13
labels
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
provider-kubernetes uses its native ManagementPolicy of which one is ObserveDelete which would translate into ["Observe", "Delete"]. We are in the process of migrating that to Crossplane core ManagementPolicies so I noticed that ["Observe", "Delete"] is not supported. TBH I dont see a reason why not to add it to supported policies.
So this PR adds ["Observe", "Delete"] to the list of supported polices.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
make reviewable test.+
Did a manual test with provider-kubernetes and an Object observing configmap. Deleting the MR, deleted the configmap.