Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Renovate to run Earthly #723

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

negz
Copy link
Member

@negz negz commented May 30, 2024

Description of your changes

Actually install it in the Renovate container, not the runner environment.

Also, run make rather than earthly on release branches.

I have:

Need help with this checklist? See the cheat sheet.

@negz negz requested a review from a team as a code owner May 30, 2024 02:27
@negz negz requested a review from bobh66 May 30, 2024 02:27
@@ -55,3 +49,6 @@ jobs:
with:
configurationFile: .github/renovate.json5
token: '${{ steps.get-github-app-token.outputs.token }}'
mount-docker-socket: true
docker-user: root
docker-cmd-file: .github/renovate-entrypoint.sh
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@negz negz force-pushed the third-rock-from-the-sun branch 2 times, most recently from d3c908a to 8b63379 Compare May 30, 2024 02:34
Actually install it in the Renovate container, not the runner
environment.

Also, run make rather than earthly on release branches.

Signed-off-by: Nic Cope <nicc@rk0n.org>
@negz negz force-pushed the third-rock-from-the-sun branch from 8b63379 to 7305ea7 Compare May 30, 2024 02:38
Copy link
Contributor

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see 🤞 FYI for tests I usually run it on my fork and merge stuff to main there, it's a bit more tedious with the gha based approach though, you have to set up the app and so on.

@negz negz merged commit 4f7275b into crossplane:master May 30, 2024
10 checks passed
@negz negz deleted the third-rock-from-the-sun branch May 30, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants