chore(deps): update dependency golangci/golangci-lint to v1.63.3 (main) #776

crossplane-renovate · 2024-09-19T08:06:46Z

This PR contains the following updates:

Package	Update	Change
golangci/golangci-lint	minor	`v1.59.0` -> `v1.63.3`

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

golangci/golangci-lint (golangci/golangci-lint)

`v1.63.3`

Compare Source

golangci-lint is a free and open-source project built by volunteers.

If you value it, consider supporting us, the maintainers and linter authors.

We appreciate it! ❤️

For key updates, see the changelog.

Changelog

bb896aa build(deps): bump github.com/ldez/exptostd from 0.3.0 to 0.3.1 (#5283)
e7a1c9f build(deps): bump github.com/ldez/usetesting from 0.4.1 to 0.4.2 (#5282)
472b9b9 build(deps): bump github.com/shirou/gopsutil/v4 from 4.24.11 to 4.24.12 (#5281)
e1b7346 fix: invalid from position (#5287)
8e4b0c3 goheader: skip issues with invalid positions (#5286)

`v1.63.2`

Compare Source

Linters bug fixes
- gofmt, gofumpt, goimports, gci: panic with several trailing EOL
- goheader: skip issues with invalid positions

`v1.63.1`

Compare Source

Linters bug fixes
- cgi: invalid reports with cgo
- gofumpt: panic with autofix and cgo

`v1.63.0`

Compare Source

Enhancements
- Add support for SuggestedFixes 🎉 (35 linters can "autofix" reports).
- Formatters (gofmt, goimports, gofumpt, gci) are applied after the suggested fixes.
New linters
- Add exptostd linter https://github.com/ldez/exptostd
- Add nilnesserr linter https://github.com/alingse/nilnesserr
- Add usetesting linter https://github.com/ldez/usetesting
Linters new features
- gci: new options: no-inline-comments, no-prefix-comments
- gomoddirectives: from 0.2.4 to 0.6.0 (new options: go-version-pattern, toolchain-pattern,toolchain-forbidden, tool-forbidden, go-debug-forbidden)
- govet: new stdversion, waitgroup analyzers
- importas: allow multiple empty aliases
- loggercheck: new slog option
- recvcheck: from 0.1.2 to 0.2.0 (new options: disable-builtin, exclusions)
- tagliatelle: from 0.5.0 to 0.7.1 (new options: ignored-fields, extended-rules,overrides, pkg, ignore)
- usestdlibvars: from 1.27.0 to 1.28.0 (autofix)
- wrapcheck: from 2.9.0 to 2.10.0 (new option: extra-ignore-sigs)
Linters bug fixes
- asciicheck: from 0.2.0 to 0.3.0
- bodyclose: from 5742072 to ed6a65f
- funlen: from 0.1.0 to 0.2.0
- ginkgolinter: from 0.18.3 to 0.18.4
- gochecksumtype: from 0.2.0 to 0.3.1
- gocognit: from 1.1.3 to 1.2.0
- godot: from 1.4.18 to 1.4.20
- goheader: report position improvement
- gosec: handling of global nosec option when it is false
- iface: from 1.2.1 to 1.3.0
- importas: from 0.1.0 to 0.2.0
- intrange: from 0.2.1 to 0.3.0
- makezero: from 1.1.1 to 1.2.0
- mirror: from 1.2.0 to 1.3.0
- nilnil: from 1.0.0 to 1.0.1
- nosprintfhostport: from 0.1.1 to 0.2.0
- reassign: from 0.2.0 to 0.3.0
- spancheck: from 0.6.2 to 0.6.4
- tagalign: from 1.3.4 to 1.4.1
- wastedassign: from 2.0.7 to 2.1.0
- whitespace: from 0.1.1 to 0.2.0
- wsl: from 4.4.1 to 4.5.0
Deprecations
- ⚠️ output.uniq-by-line is deprecated and replaced by issues.uniq-by-line.
Misc.
- Improvements of the help command (color and JSON support).
- Removes decoder, sloglint, tagalin from format preset.
- Enables paths with junction inside Windows.
- The timeout is disabled if run.timeout <= 0.

`v1.62.2`

Compare Source

Linters bug fixes
- fatcontext: from 0.5.2 to 0.5.3
- ginkgolinter: from 0.18.0 to 0.18.3
- errorlint: from 1.6.0 to 1.7.0
- iface: from 1.2.0 to 1.2.1
- revive: from 1.5.0 to 1.5.1
- testifylint: from 1.5.0 to 1.5.2
Misc.
- fix: ignore cache error when file not found

`v1.62.0`

Compare Source

New linters
- Add recvcheck linter https://github.com/raeperd/recvcheck
- Add iface linter https://github.com/uudashr/iface
Linters new features
- ginkgolinter: from 0.17.0 to 0.18.0 (new option: force-succeed)
- gochecksumtype: from 0.1.4 to 0.2.0 (new option: default-signifies-exhaustive)
- loggercheck: from 0.9.4 to 0.10.1 (log/slog support)
- nilnil: from 0.1.9 to 1.0.0 (new option: detect-opposite)
- revive: from 1.3.9 to 1.5.0 (new rules: filename-format, and file-length-limit)
- tenv: from 1.10.0 to 1.12.1 (handle dot import)
- testifylint: from 1.4.3 to 1.5.0 (new checkers: contains, encoded-compare, regexp)
Linters bug fixes
- bidichk: from 0.2.7 to 0.3.2 (important performance improvement)
- canonicalheader: from 1.1.1 to 1.1.2
- cyclop: from 1.2.1 to 1.2.3
- dupword: from 0.1.1 to 0.1.3
- errcheck: from 1.7.0 to 1.8.0
- errchkjson: from 0.3.6 to 0.4.0
- errname: from 0.1.13 to 1.0.0
- gocritic: from 0.11.4 to 0.11.5
- goprintffuncname: from 7558a9e to v0.1.0
- godot: from 1.4.17 to 1.4.18
- gosec: from 2.21.2 to 2.21.4
- intrange: from 0.2.0 to 0.2.1
- musttag: from 0.12.2 to 0.13.0
- nakedret: from 2.0.4 to 2.0.5
- noctx: from 0.0.2 to 0.1.0
- protogetter: from 0.3.6 to 0.3.8
Deprecations
- ⚠️ execinquery: deprecation step 2
- ⚠️ gomnd: deprecation step 2 (replaced by mnd)
Misc.
- Type sizing when cross-compiling (32-bit).
- code-climate: add check_name field
- Improve Go version detection
- Fix Go version propagation
Documentation
- Adds a section about exclude-dirs-use-default
- Improve 'install from sources' section
- Improve FAQ about Go versions
- Improve linter/rule/check docs
- Improve new linter section
- Improve forbidigo pattern examples for built-in functions

`v1.61.0`

Compare Source

Enhancements
- Add junit-xml-extended format
- Exclude Swagger Codegen files by default
Linters new features
- gci: from 0.13.4 to 0.13.5 (new option no-lex-order)
- nolintlint: remove the empty line in the directive replacement
Linters bug fixes
- dupword: from 0.0.14 to 0.1.1
- fatcontext: from 0.4.0 to 0.5.2
- go-ruleguard: from 0.4.2 to 0fe6f58 (fix panic with custom linters)
- godot: from 1.4.16 to 1.4.17
- gomodguard: from 1.3.3 to 1.3.5
- gosec: disable temporarily G407
- gosec: from ab3f6c1 to 2.21.2 (partially fix G115)
- intrange: from 0.1.2 to 0.2.0
Misc.
- Improve runtime version parsing
Documentation
- Add additional info about typecheck

`v1.60.3`

Compare Source

Updated linters
- gosec: from 81cda2f to ab3f6c1 (fix G115 false positives)
Misc.
- Check that the Go version use to build is greater or equals to the Go version of the project

`v1.60.2`

Compare Source

Linters new features
- gosec: from 5f0084e to 81cda2f (adds G115, G405, G406, G506, G507)
Linters bug fixes
- gofmt: update to HEAD (go1.22)
- gofumpt: from 0.6.0 to 0.7.0
- gosec: fix G602 analyzer
- staticcheck: from 0.5.0 to 0.5.1
- staticcheck: propagate Go version
- wrapcheck: from 2.8.3 to 2.9.0
Deprecations
- ⚠️ exportloopref: deprecation

`v1.60.1`

Compare Source

Misc.
- 🎉 go1.23 support
Linters new features
- exhaustruct: from 3.2.0 to 3.3.0 (recognize custom error values in return)
- govet (printf): report non-constant format, no args
- lll: advertise max line length instead of just reporting failure
- revive: from 1.3.7 to 1.3.9 (new rule: comments-density)
- staticcheck: from 0.4.7 to 0.5.0
- testifylint: from 1.3.1 to 1.4.3 (new options: formatter, suite-broken-parallel, suite-subtest-run)
Linters bug fixes
- errorlint: from 1.5.2 to 1.6.0
- fatcontext: from 0.2.2 to 0.4.0 (fix false positives for context stored in structs)
- gocognit: from 1.1.2 to 1.1.3
- gomodguard: from 1.3.2 to 1.3.3
- sloglint: from 0.7.1 to 0.7.2
- spancheck: from 0.6.1 to 0.6.2
- tenv: from 1.7.1 to 1.10.0 (remove reports on fuzzing)
- tparallel: from 0.3.1 to 0.3.2
- usestdlibvars: from 1.26.0 to 1.27.0 (fix false-positive with number used inside a mathematical operations)
- wsl: from 4.2.1 to 4.4.1
Deprecations
- ️⚠️ unused: remove exported-is-used option
Fixes
- SARIF: sanitize level property
- ️⚠️ typecheck issues should never be ignored
Documentation
- Add link on linter without configuration
- Remove 'trusted by' page
- wsl update documentation of the configuration

`v1.59.1`

Compare Source

Updated linters
- errorlint: from 1.5.1 to 1.5.2
- gomnd: deprecated configuration compatibility
- intrange: add style preset
- misspell: from 0.5.1 to 0.6.0
- sloglint: from 0.7.0 to 0.7.1
- testifylint: from 1.3.0 to 1.3.1
- unparam: bump to HEAD
- usestdlibvars: from 1.25.0 to 1.26.0
Fixes
- SARIF: init empty result slice
- SARIF: issue column >= 1
Documentation
- revive: update documentation of the configuration

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

crossplane-renovate · 2024-09-19T08:06:48Z

⚠️ Artifact update problem

Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Earthfile

Command failed: earthly --strict +go-lint
 Init 🚀
————————————————————————————————————————————————————————————————————————————————

           buildkitd | Found buildkit daemon as docker container (earthly-buildkitd)

 Build 🔧
————————————————————————————————————————————————————————————————————————————————

              logbus | Setting organization "crossplane" and project "crossplane-runtime"
            +go-lint | --> FROM +base
            +go-lint | --> FROM +go-modules
         +go-modules | --> FROM +base
       golang:1.22.3 | --> Load metadata golang:1.22.3 linux/amd64
Warning: you are not logged into registry-1.docker.io, you may experience rate-limitting when pulling images
         +go-modules | --> FROM golang:1.22.3
         +go-modules | [----------] 100% FROM golang:1.22.3�[K
         +go-modules | [          ]   0% FROM golang:1.22.3�[K
         +go-modules | �[A[----------] 100% FROM golang:1.22.3�[K
         +go-modules | --> WORKDIR /crossplane
         +go-modules | --> COPY go.mod go.sum ./
         +go-modules | --> RUN go mod download
            +go-lint | --> RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT_VERSION}
            +go-lint | golangci/golangci-lint info checking GitHub for tag 'v1.63.3'
            +go-lint | golangci/golangci-lint info found version: 1.63.3 for v1.63.3/linux/amd64
            +go-lint | golangci/golangci-lint info installed /go/bin/golangci-lint
            +go-lint | --> COPY .golangci.yml .
            +go-lint | --> COPY --dir apis/ pkg/ .
            +go-lint | --> RUN golangci-lint run --fix
            +go-lint | level=warning msg="[config_reader] The configuration option `linters.unused.exported-is-used` is deprecated."
            +go-lint | level=warning msg="[lintersdb] The linter \"execinquery\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle"
            +go-lint | level=warning msg="[lintersdb] The linter \"gomnd\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle"
            +go-lint | pkg/fieldpath/paved.go:124:10: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 			if int(current.Index) >= len(array) {
            +go-lint | 			      ^
            +go-lint | pkg/fieldpath/paved.go:430:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	if int(next.Index) < len(na) {
            +go-lint | 	      ^
            +go-lint | pkg/fieldpath/paved.go:434:51: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	array[current.Index] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint | 	                                                 ^
            +go-lint | pkg/fieldpath/paved.go:461:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	if int(next.Index) < len(na) {
            +go-lint | 	      ^
            +go-lint | pkg/fieldpath/paved.go:465:52: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	object[current.Field] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint | 	                                                  ^
            +go-lint | pkg/fieldpath/paved.go:546:24: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 			if len(array) <= int(current.Index) {
            +go-lint | 			                    ^
            +go-lint | pkg/fieldpath/paved.go:596:42: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 		if len(array) == 0 || len(array) <= int(s.Index) {
            +go-lint | 		                                       ^
            +go-lint | pkg/fieldpath/paved.go:599:15: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 		for i := int(s.Index); i < len(array)-1; i++ {
            +go-lint | 		            ^
            +go-lint | pkg/fieldpath/paved.go:78:28: redefines-builtin-id: redefinition of the built-in function max (revive)
            +go-lint | func WithMaxFieldPathIndex(max uint) PavedOption {
            +go-lint |                            ^
            +go-lint | pkg/fieldpath/paved.go:31:6: the error type name `errNotFound` should conform to the `xxxError` format (errname)
            +go-lint | type errNotFound struct {
            +go-lint |      ^
            +go-lint | pkg/resource/providerconfig.go:45:6: the error type name `errMissingRef` should conform to the `xxxError` format (errname)
            +go-lint | type errMissingRef struct{ error }
            +go-lint |      ^
            +go-lint | pkg/resource/resource.go:275:6: the error type name `errNotControllable` should conform to the `xxxError` format (errname)
            +go-lint | type errNotControllable struct{ error }
            +go-lint |      ^
            +go-lint | pkg/resource/resource.go:347:6: the error type name `errNotAllowed` should conform to the `xxxError` format (errname)
            +go-lint | type errNotAllowed struct{ error }
            +go-lint |      ^
            +go-lint | apis/common/v1/condition.go:71:6: the methods of "Condition" use pointer receiver and non-pointer receiver. (recvcheck)
            +go-lint | type Condition struct {
            +go-lint |      ^
            +go-lint | ERROR Earthfile:113:2
            +go-lint |       The command
            +go-lint |           RUN golangci-lint run --fix
            +go-lint |       did not complete successfully. Exit code 1

================================== ❌ FAILURE ===================================

            +go-lint *failed* | Repeating the failure error...
            +go-lint *failed* | --> RUN golangci-lint run --fix
            +go-lint *failed* | level=warning msg="[config_reader] The configuration option `linters.unused.exported-is-used` is deprecated."
            +go-lint *failed* | level=warning msg="[lintersdb] The linter \"execinquery\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle"
            +go-lint *failed* | level=warning msg="[lintersdb] The linter \"gomnd\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle"
            +go-lint *failed* | pkg/fieldpath/paved.go:124:10: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 			if int(current.Index) >= len(array) {
            +go-lint *failed* | 			      ^
            +go-lint *failed* | pkg/fieldpath/paved.go:430:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	if int(next.Index) < len(na) {
            +go-lint *failed* | 	      ^
            +go-lint *failed* | pkg/fieldpath/paved.go:434:51: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	array[current.Index] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint *failed* | 	                                                 ^
            +go-lint *failed* | pkg/fieldpath/paved.go:461:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	if int(next.Index) < len(na) {
            +go-lint *failed* | 	      ^
            +go-lint *failed* | pkg/fieldpath/paved.go:465:52: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	object[current.Field] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint *failed* | 	                                                  ^
            +go-lint *failed* | pkg/fieldpath/paved.go:546:24: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 			if len(array) <= int(current.Index) {
            +go-lint *failed* | 			                    ^
            +go-lint *failed* | pkg/fieldpath/paved.go:596:42: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 		if len(array) == 0 || len(array) <= int(s.Index) {
            +go-lint *failed* | 		                                       ^
            +go-lint *failed* | pkg/fieldpath/paved.go:599:15: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 		for i := int(s.Index); i < len(array)-1; i++ {
            +go-lint *failed* | 		            ^
            +go-lint *failed* | pkg/fieldpath/paved.go:78:28: redefines-builtin-id: redefinition of the built-in function max (revive)
            +go-lint *failed* | func WithMaxFieldPathIndex(max uint) PavedOption {
            +go-lint *failed* |                            ^
            +go-lint *failed* | pkg/fieldpath/paved.go:31:6: the error type name `errNotFound` should conform to the `xxxError` format (errname)
            +go-lint *failed* | type errNotFound struct {
            +go-lint *failed* |      ^
            +go-lint *failed* | pkg/resource/providerconfig.go:45:6: the error type name `errMissingRef` should conform to the `xxxError` format (errname)
            +go-lint *failed* | type errMissingRef struct{ error }
            +go-lint *failed* |      ^
            +go-lint *failed* | pkg/resource/resource.go:275:6: the error type name `errNotControllable` should conform to the `xxxError` format (errname)
            +go-lint *failed* | type errNotControllable struct{ error }
            +go-lint *failed* |      ^
            +go-lint *failed* | pkg/resource/resource.go:347:6: the error type name `errNotAllowed` should conform to the `xxxError` format (errname)
            +go-lint *failed* | type errNotAllowed struct{ error }
            +go-lint *failed* |      ^
            +go-lint *failed* | apis/common/v1/condition.go:71:6: the methods of "Condition" use pointer receiver and non-pointer receiver. (recvcheck)
            +go-lint *failed* | type Condition struct {
            +go-lint *failed* |      ^
            +go-lint *failed* | ERROR Earthfile:113:2
            +go-lint *failed* |       The command
            +go-lint *failed* |           RUN golangci-lint run --fix
            +go-lint *failed* |       did not complete successfully. Exit code 1

Help: To debug your build, you can use the --interactive (-i) flag to drop into a shell of the failing RUN step: "earthly -i --strict +go-lint"

🛰️ Reuse cache between CI runs with Earthly Satellites! 2-20X faster than without cache. Generous free tier https://cloud.earthly.dev

File name: Earthfile

Command failed: earthly --strict +go-lint
 Init 🚀
————————————————————————————————————————————————————————————————————————————————

           buildkitd | Found buildkit daemon as docker container (earthly-buildkitd)

 Build 🔧
————————————————————————————————————————————————————————————————————————————————

              logbus | Setting organization "crossplane" and project "crossplane-runtime"
            +go-lint | --> FROM +base
            +go-lint | --> FROM +go-modules
         +go-modules | --> FROM +base
       golang:1.22.3 | --> Load metadata golang:1.22.3 linux/amd64
         +go-modules | --> FROM golang:1.22.3
         +go-modules | [----------] 100% FROM golang:1.22.3�[K
         +go-modules | *cached* --> WORKDIR /crossplane
         +go-modules | *cached* --> COPY go.mod go.sum ./
         +go-modules | *cached* --> RUN go mod download
            +go-lint | *cached* --> RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT_VERSION}
            +go-lint | *cached* --> COPY .golangci.yml .
            +go-lint | *cached* --> COPY --dir apis/ pkg/ .
            +go-lint | --> RUN golangci-lint run --fix
            +go-lint | level=warning msg="[config_reader] The configuration option `linters.unused.exported-is-used` is deprecated."
            +go-lint | level=warning msg="[lintersdb] The linter \"execinquery\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle"
            +go-lint | level=warning msg="[lintersdb] The linter \"gomnd\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle"
            +go-lint | apis/common/v1/condition.go:71:6: the methods of "Condition" use pointer receiver and non-pointer receiver. (recvcheck)
            +go-lint | type Condition struct {
            +go-lint |      ^
            +go-lint | pkg/resource/providerconfig.go:45:6: the error type name `errMissingRef` should conform to the `xxxError` format (errname)
            +go-lint | type errMissingRef struct{ error }
            +go-lint |      ^
            +go-lint | pkg/resource/resource.go:275:6: the error type name `errNotControllable` should conform to the `xxxError` format (errname)
            +go-lint | type errNotControllable struct{ error }
            +go-lint |      ^
            +go-lint | pkg/resource/resource.go:347:6: the error type name `errNotAllowed` should conform to the `xxxError` format (errname)
            +go-lint | type errNotAllowed struct{ error }
            +go-lint |      ^
            +go-lint | pkg/fieldpath/paved.go:124:10: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 			if int(current.Index) >= len(array) {
            +go-lint | 			      ^
            +go-lint | pkg/fieldpath/paved.go:430:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	if int(next.Index) < len(na) {
            +go-lint | 	      ^
            +go-lint | pkg/fieldpath/paved.go:434:51: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	array[current.Index] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint | 	                                                 ^
            +go-lint | pkg/fieldpath/paved.go:461:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	if int(next.Index) < len(na) {
            +go-lint | 	      ^
            +go-lint | pkg/fieldpath/paved.go:465:52: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 	object[current.Field] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint | 	                                                  ^
            +go-lint | pkg/fieldpath/paved.go:546:24: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 			if len(array) <= int(current.Index) {
            +go-lint | 			                    ^
            +go-lint | pkg/fieldpath/paved.go:596:42: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 		if len(array) == 0 || len(array) <= int(s.Index) {
            +go-lint | 		                                       ^
            +go-lint | pkg/fieldpath/paved.go:599:15: G115: integer overflow conversion uint -> int (gosec)
            +go-lint | 		for i := int(s.Index); i < len(array)-1; i++ {
            +go-lint | 		            ^
            +go-lint | pkg/fieldpath/paved.go:78:28: redefines-builtin-id: redefinition of the built-in function max (revive)
            +go-lint | func WithMaxFieldPathIndex(max uint) PavedOption {
            +go-lint |                            ^
            +go-lint | pkg/fieldpath/paved.go:31:6: the error type name `errNotFound` should conform to the `xxxError` format (errname)
            +go-lint | type errNotFound struct {
            +go-lint |      ^
            +go-lint | ERROR Earthfile:113:2
            +go-lint |       The command
            +go-lint |           RUN golangci-lint run --fix
            +go-lint |       did not complete successfully. Exit code 1

================================== ❌ FAILURE ===================================

            +go-lint *failed* | Repeating the failure error...
            +go-lint *failed* | --> RUN golangci-lint run --fix
            +go-lint *failed* | level=warning msg="[config_reader] The configuration option `linters.unused.exported-is-used` is deprecated."
            +go-lint *failed* | level=warning msg="[lintersdb] The linter \"execinquery\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle"
            +go-lint *failed* | level=warning msg="[lintersdb] The linter \"gomnd\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle"
            +go-lint *failed* | apis/common/v1/condition.go:71:6: the methods of "Condition" use pointer receiver and non-pointer receiver. (recvcheck)
            +go-lint *failed* | type Condition struct {
            +go-lint *failed* |      ^
            +go-lint *failed* | pkg/resource/providerconfig.go:45:6: the error type name `errMissingRef` should conform to the `xxxError` format (errname)
            +go-lint *failed* | type errMissingRef struct{ error }
            +go-lint *failed* |      ^
            +go-lint *failed* | pkg/resource/resource.go:275:6: the error type name `errNotControllable` should conform to the `xxxError` format (errname)
            +go-lint *failed* | type errNotControllable struct{ error }
            +go-lint *failed* |      ^
            +go-lint *failed* | pkg/resource/resource.go:347:6: the error type name `errNotAllowed` should conform to the `xxxError` format (errname)
            +go-lint *failed* | type errNotAllowed struct{ error }
            +go-lint *failed* |      ^
            +go-lint *failed* | pkg/fieldpath/paved.go:124:10: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 			if int(current.Index) >= len(array) {
            +go-lint *failed* | 			      ^
            +go-lint *failed* | pkg/fieldpath/paved.go:430:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	if int(next.Index) < len(na) {
            +go-lint *failed* | 	      ^
            +go-lint *failed* | pkg/fieldpath/paved.go:434:51: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	array[current.Index] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint *failed* | 	                                                 ^
            +go-lint *failed* | pkg/fieldpath/paved.go:461:8: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	if int(next.Index) < len(na) {
            +go-lint *failed* | 	      ^
            +go-lint *failed* | pkg/fieldpath/paved.go:465:52: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 	object[current.Field] = append(na, make([]any, int(next.Index)-len(na)+1)...)
            +go-lint *failed* | 	                                                  ^
            +go-lint *failed* | pkg/fieldpath/paved.go:546:24: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 			if len(array) <= int(current.Index) {
            +go-lint *failed* | 			                    ^
            +go-lint *failed* | pkg/fieldpath/paved.go:596:42: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 		if len(array) == 0 || len(array) <= int(s.Index) {
            +go-lint *failed* | 		                                       ^
            +go-lint *failed* | pkg/fieldpath/paved.go:599:15: G115: integer overflow conversion uint -> int (gosec)
            +go-lint *failed* | 		for i := int(s.Index); i < len(array)-1; i++ {
            +go-lint *failed* | 		            ^
            +go-lint *failed* | pkg/fieldpath/paved.go:78:28: redefines-builtin-id: redefinition of the built-in function max (revive)
            +go-lint *failed* | func WithMaxFieldPathIndex(max uint) PavedOption {
            +go-lint *failed* |                            ^
            +go-lint *failed* | pkg/fieldpath/paved.go:31:6: the error type name `errNotFound` should conform to the `xxxError` format (errname)
            +go-lint *failed* | type errNotFound struct {
            +go-lint *failed* |      ^
            +go-lint *failed* | ERROR Earthfile:113:2
            +go-lint *failed* |       The command
            +go-lint *failed* |           RUN golangci-lint run --fix
            +go-lint *failed* |       did not complete successfully. Exit code 1

Help: To debug your build, you can use the --interactive (-i) flag to drop into a shell of the failing RUN step: "earthly -i --strict +go-lint"

🛰️ Reuse cache between CI runs with Earthly Satellites! 2-20X faster than without cache. Generous free tier https://cloud.earthly.dev

crossplane-renovate bot requested a review from a team as a code owner September 19, 2024 08:06

crossplane-renovate bot added the automated label Sep 19, 2024

crossplane-renovate bot requested a review from phisco September 19, 2024 08:06

crossplane-renovate bot force-pushed the renovate/main-golangci-golangci-lint-1.x branch from 389f73b to b8993b3 Compare November 11, 2024 08:06

crossplane-renovate bot changed the title ~~chore(deps): update dependency golangci/golangci-lint to v1.61.0 (main)~~ chore(deps): update dependency golangci/golangci-lint to v1.62.0 (main) Nov 11, 2024

crossplane-renovate bot force-pushed the renovate/main-golangci-golangci-lint-1.x branch from b8993b3 to 611d0d0 Compare November 26, 2024 08:06

crossplane-renovate bot changed the title ~~chore(deps): update dependency golangci/golangci-lint to v1.62.0 (main)~~ chore(deps): update dependency golangci/golangci-lint to v1.62.2 (main) Nov 26, 2024

crossplane-renovate bot force-pushed the renovate/main-golangci-golangci-lint-1.x branch from 611d0d0 to b7f1b20 Compare January 2, 2025 08:06

crossplane-renovate bot changed the title ~~chore(deps): update dependency golangci/golangci-lint to v1.62.2 (main)~~ chore(deps): update dependency golangci/golangci-lint to v1.63.1 (main) Jan 2, 2025

chore(deps): update dependency golangci/golangci-lint to v1.63.3

ecb7ea3

crossplane-renovate bot force-pushed the renovate/main-golangci-golangci-lint-1.x branch from b7f1b20 to ecb7ea3 Compare January 3, 2025 08:07

crossplane-renovate bot changed the title ~~chore(deps): update dependency golangci/golangci-lint to v1.63.1 (main)~~ chore(deps): update dependency golangci/golangci-lint to v1.63.3 (main) Jan 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update dependency golangci/golangci-lint to v1.63.3 (main) #776

chore(deps): update dependency golangci/golangci-lint to v1.63.3 (main) #776

crossplane-renovate bot commented Sep 19, 2024 •

edited

Loading

crossplane-renovate bot commented Sep 19, 2024 •

edited

Loading

chore(deps): update dependency golangci/golangci-lint to v1.63.3 (main) #776

Are you sure you want to change the base?

chore(deps): update dependency golangci/golangci-lint to v1.63.3 (main) #776

Conversation

crossplane-renovate bot commented Sep 19, 2024 • edited Loading

Release Notes

Changelog

Configuration

crossplane-renovate bot commented Sep 19, 2024 • edited Loading

⚠️ Artifact update problem

File name: Earthfile

File name: Earthfile

crossplane-renovate bot commented Sep 19, 2024 •

edited

Loading

crossplane-renovate bot commented Sep 19, 2024 •

edited

Loading