chore: adding optional caller skip and an option to encode time in iso8601 for production logger #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chaitanya Kolluru <chaitanya.r.kolluru@gmail.com>
Signed-off-by: Chaitanya Kolluru <chaitanya.r.kolluru@gmail.com>
chaitanyakolluru
force-pushed
the
prod-logger-updates
branch
from
ef3c61e
to
48f8c53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds options to NewLogger function to encode time in iso8601 format for production environments and set a different caller skip number when initializing the logger.
Fixes #146
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Tested manually against a Composition function running in local kind cluster.