This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 80
add observedGeneration to represent Component and AppConfig has reconciled #91
Labels
Comments
wonderflow
added
good first issue
Good for newcomers
enhancement
New feature or request
labels
Jul 9, 2020
wonderflow
changed the title
add observedGeneration into status of Component and AppConfig CR
add observedGeneration into status of Component and AppConfig
Jul 9, 2020
wonderflow
changed the title
add observedGeneration into status of Component and AppConfig
add observedGeneration to represent Component and AppConfig has reconciled successfully
Jul 9, 2020
wonderflow
changed the title
add observedGeneration to represent Component and AppConfig has reconciled successfully
add observedGeneration to represent Component and AppConfig has reconciled
Jul 9, 2020
/assign |
@LeoLiuYan Thanks |
This is a kindly ping. Hi @LeoLiuYan, have you started? |
Oh.. not yet. I will start in this weekend. |
@LeoLiuYan Hi, are you still interested on this work? |
Yes, I will submit a PR as soon as possible. |
/assign @Ghostbaby |
Ghostbaby
added a commit
to Ghostbaby/oam-kubernetes-runtime
that referenced
this issue
Sep 13, 2020
Add observedGeneration to represent Component Fix crossplane#91 Signed-off-by: zhuhuijun <zhuhuijunzhj@gmail.com>
wonderflow
pushed a commit
that referenced
this issue
Sep 28, 2020
* feat(component):Add observedGeneration to represent Component Add observedGeneration to represent Component Fix #91 Signed-off-by: zhuhuijun <zhuhuijunzhj@gmail.com> * feat(component):Add observedGeneration to represent Component Add observedGeneration to represent Component Fix #205 Signed-off-by: zhuhuijun <zhuhuijunzhj@gmail.com> * mv updateObservedGeneration Signed-off-by: zhuhuijun <zhuhuijunzhj@gmail.com> * fix check-diff Signed-off-by: zhuhuijun <zhuhuijunzhj@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
observedGeneration
field of status in K8s object is widely used in K8s built-in resource. It reflects the generation of the most recently observed Object.With the help of
observedGeneration
field, user can recognize whether a CR is reconciled by controller.A workflow will like below:
After the controller reconciled, the
observedGeneration
will appear and align withgeneration
in metadata:Later, we have another change, it will be:
And after reconciled, it will be:
Also, CR of AppConfig also need to add this field.
The text was updated successfully, but these errors were encountered: