This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
[WIP]Component versioning fix and e2e tests #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: roy wang <seiwy2010@gmail.com>
allow multiple revisions of one component unit test & e2e test Signed-off-by: roy wang <seiwy2010@gmail.com>
Signed-off-by: roy wang <seiwy2010@gmail.com>
wonderflow
reviewed
Aug 9, 2020
Comment on lines
+147
to
+148
| Name: revisionName, | ||
| Namespace: curComp.Namespace, |
There was a problem hiding this comment.
could you help split the namespace in a separated PR as a BUG fix, thanks.
There was a problem hiding this comment.
Sure, I will fix it in another PR.
wonderflow
reviewed
Aug 9, 2020
Comment on lines
+376
to
+387
| - revisionName: example-component-1 | ||
| traits: | ||
| - apiversion:core.oam.dev/v1alpha2 | ||
| kind: ManualScaler | ||
| spec: | ||
| replicaCount: 3 | ||
| - revisionName: example-component-2 | ||
| traits: | ||
| - apiversion:core.oam.dev/v1alpha2 | ||
| kind: ManualScaler | ||
| spec: | ||
| replicaCount: 2 |
There was a problem hiding this comment.
We are considering it's an anti-pattern, as we could use two different components to do the same thing. Using different revisions of one component seems don't bring any extra bonus.
There was a problem hiding this comment.
Okay, before the proposal is ready, let's suspend this PR. But I will separate e2e test covering current versioning mechanism into another PR as well as the fix of #170.
There was a problem hiding this comment.
Cool, we can hold this PR until we have a conclusion on that issue
captainroy-hy
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change: set workload instance name as specified revisionName, if revisionName is provided.