Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

Fix helm chart template format issues #206

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Fix helm chart template format issues #206

merged 1 commit into from
Sep 14, 2020

Conversation

SataQiu
Copy link
Contributor

@SataQiu SataQiu commented Sep 13, 2020

nodeSelector should be a member of spec.template.spec, not spec.template.

The error reported by Helm is:

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Deployment.spec.template): unknown field "nodeSelector" in io.k8s.api.core.v1.PodTemplateSpec

affinity and tolerations have similar problems :(

@SataQiu
fix helm chart template format
d9752e5 
Signed-off-by: SataQiu <1527062125@qq.com>
@SataQiu
Copy link
Contributor Author

SataQiu commented Sep 13, 2020

/assign @wonderflow

wonderflow
wonderflow approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@wonderflow wonderflow merged commit a760d93 into crossplane:master Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wonderflow wonderflow wonderflow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SataQiu @wonderflow