This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
Use AppConfig's generation to get latest dependency only #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongchaodeng
force-pushed
the
dep
branch
2 times, most recently
from
a35dd79
to
b25cd2f
Compare
Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
- pass AC's generation into child objects' labels - check generation in getting data input Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
Signed-off-by: Hongchao Deng <hongchaodeng1@gmail.com>
wonderflow
suggested changes
Sep 29, 2020
Comment on lines
+511
to
+513
| if g1, g2 := u.GetLabels()[oam.LabelAppGeneration], strconv.Itoa(acGeneration); g1 != g2 { | ||
| return nil, false, fmt.Sprintf("generation not match: obj (%s), ac (%s)", g1, g2), nil | ||
| } |
There was a problem hiding this comment.
The object can be workload or trait. The object will always have this label, it is meaningless to check. We should check status is updated to align this label.
And also, this is a break change, I don't think we need to make it as a force check.
Co-authored-by: Jianbo Sun <wonderflow.sun@gmail.com>
|
After discussion, this PR will not fix #222 because it also requires the trait operator to update the data in trait CR. So waiting for label to be updated is still not enough. Therefore, the data flow involves both OAM Runtime and the Trait Operators. We will put this on hold and come back to this once we have an ideal solution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #222