This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
minor fix datarace #257
Merged
minor fix datarace #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
| @@ -133,38 +133,39 @@ func newTrue() *bool { | |||
|
|
|||
| func (c *ComponentHandler) createControllerRevision(mt metav1.Object, obj runtime.Object) bool { | |||
| curComp := obj.(*v1alpha2.Component) | |||
| diff, curRevision := c.IsRevisionDiff(mt, curComp) | |||
| comp := curComp.DeepCopy() | |||
There was a problem hiding this comment.
It seems the controller runtime already returns a copy from the informer queue(client go, tools/cache/delta_fifo.go:486), is it?
There was a problem hiding this comment.
I'm afraid not, currently vela complains the error: https://github.com/oam-dev/kubevela/runs/1272425015
After debug, I found out it because of this not copy.
There was a problem hiding this comment.
Well, the event handler passes the object reference directly:
// OnAdd creates CreateEvent and calls Create on EventHandler
func (e EventHandler) OnAdd(obj interface{}) {
...
// Pull the runtime.Object out of the object
if o, ok := obj.(runtime.Object); ok {
c.Object = o
} 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.