This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
[ISSUE #270] Bug fixed, OAM example can not run correctlly. #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderflow
reviewed
Oct 27, 2020
Comment on lines
95
to
102
| - host: x.oam.dev | ||
| http: | ||
| paths: | ||
| - backend: | ||
| serviceName: web-ui | ||
| servicePort: 8080 | ||
| path: / |
There was a problem hiding this comment.
Users don't own this domain and could not view it if we setting like this. Please keep the original way, thanks.
There was a problem hiding this comment.
ok, i will keep the original way.
Comment on lines
-12
to
-14
| - apiVersion: core.oam.dev/v1alpha2 | ||
| kind: ContainerizedWorkload | ||
| name: example-component2 |
There was a problem hiding this comment.
Because Application does not contain a component named example-component2 or example-component1。It contains a component named web-service-component.
…ssion to add, delete, modify and check the CRD, the oam example cannot be run correcttly. Signed-off-by: linjie.miao <linjie.miao@silot.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed four examples in total:
1） component revsion name format changed in example component-versioning
2) add clusterrole [KIND=Foo] in dependency example
3) add clusterrole [KIND=Ingress] in flight-tracker example
4) change example-health-scope's workloadrefs in typed-component example