This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
add OAM policy design #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderflow
reviewed
Jun 15, 2020
| containers: | ||
| - name: mysql | ||
| image: mysql:latest | ||
| policies |
There was a problem hiding this comment.
Suggested change
| policies | |
| policies: |
| containers: | ||
| - name: wordpress | ||
| image: wordpress:latest | ||
| policies |
There was a problem hiding this comment.
Suggested change
| policies | |
| policies: |
| database component in a master only mode. Therefore, an application operator cannot apply a | ||
| `ManualScalerTrait` to the `example-db` component. In the same time, let's say that the | ||
| `example-web` component developer wants to expose the component to the internet. This | ||
| means that an application operator needs to know that it should apply an `IngressTrait' to |
There was a problem hiding this comment.
Suggested change
| means that an application operator needs to know that it should apply an `IngressTrait' to | |
| means that an application operator needs to know that it should apply an `IngressTrait` to |
| image: mysql:latest | ||
| policies | ||
| - type: maxInstancePolicy | ||
| value: 1 |
There was a problem hiding this comment.
- type: replicaPolicy
value: singleton
|
I think this proposal is missing the problem background and use cases. Would like to see them added first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an initial OAM Policy design