This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Start shared native provider using a magic cookie #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
2 tasks
muvaf
approved these changes
Apr 20, 2022
pkg/terraform/provider_runner.go
Outdated
| // NewSharedProvider instantiates a SharedProvider with an | ||
| // OS executor using the supplied logger | ||
| func NewSharedProvider(l logging.Logger, nativeProviderPath string, opts ...SharedGRPCRunnerOption) *SharedProvider { | ||
| func NewSharedProvider(l logging.Logger, nativeProviderPath, nativeProviderName string, protocolVersion int, opts ...SharedGRPCRunnerOption) *SharedProvider { |
There was a problem hiding this comment.
We talked about this offline and it seems protocolVersion is not easily found by users and it's 5 for all the big three. So, having this value as default and overridden optionally similar to magic cookie could make it easier for folks to use this method.
There was a problem hiding this comment.
Thanks @muvaf! We now default to 5 as the gRPC protocol version.
pkg/terraform/provider_runner.go
Outdated
| fmtSetEnv = "%s=%s" | ||
| envReattachConfig = "TF_REATTACH_PROVIDERS" | ||
| envMagicCookie = "TF_PLUGIN_MAGIC_COOKIE" | ||
| defaultMagicCookie = "d602bf8f470bc67ca7faa0386276bbdd4330efaf76d1a219cb4d6991ca9872b2" |
There was a problem hiding this comment.
Could you add a comment about how we found this value?
…er to 5 Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
grpc-configure-regex
branch
from
c80bf16 to
508b40c
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
It turns out that we cannot run the Terraform GCP provider as a shared server like we do for the AWS and Azure providers (by invoking the plugin binary with certain command-line options). We have identified another way in which we set a cookie in the native provider's environment to keep it running as a shared server. This PR switches to this method in the
SharedProviderimplementation.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
provider-jet-awsboth locally & in-cluster with a provider package by provisioning and destroying a VPC. Related PR: Switch to shared gRPC server implementation crossplane-contrib/provider-jet-aws#182provider-jet-gcpboth locally & in-cluster with a provider package by provisioning and destroying a ServiceAccount. Related PR: Switch to shared gRPC server implementation crossplane-contrib/provider-jet-gcp#58provider-jet-azureboth locally & in-cluster with a provider package by importing a ResourceGroup. Related PR: Fork shared gRPC server with the magic cookie crossplane-contrib/provider-jet-azure#179