Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates source code for ownership change #59

Closed
wants to merge 5 commits into from

Conversation

jeanduplessis
Copy link
Collaborator

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@jeanduplessis jeanduplessis force-pushed the ownership_change branch 2 times, most recently from 35645e7 to 6b56b8d Compare November 13, 2023 16:01
Signed-off-by: Jean du Plessis <jean@upbound.io>
Comment on lines +47 to +48
- prefix(github.com/crossplane/crossplane-runtime)
- prefix(github.com/crossplane/crossplane)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we conventionally do is to have the prefixes of the current project in a separate import section, e.g.:

import (
	"time"

	"github.com/crossplane/crossplane-runtime/pkg/connection"
	"github.com/crossplane/crossplane-runtime/pkg/event"
	"github.com/crossplane/crossplane-runtime/pkg/ratelimiter"
	"github.com/crossplane/crossplane-runtime/pkg/reconciler/managed"
	xpresource "github.com/crossplane/crossplane-runtime/pkg/resource"
	tjcontroller "github.com/crossplane/upjet/pkg/controller"
	"github.com/crossplane/upjet/pkg/controller/handler"
	"github.com/crossplane/upjet/pkg/terraform"
	ctrl "sigs.k8s.io/controller-runtime"

	v1alpha1 "github.com/upbound/upjet-provider-template/apis/null/v1alpha1"
	features "github.com/upbound/upjet-provider-template/internal/features"
)
Suggested change
- prefix(github.com/crossplane/crossplane-runtime)
- prefix(github.com/crossplane/crossplane)
- prefix(github.com/crossplane/upjet-provider-template)


skip-files:
- "zz_\\..+\\.go$"
- "zz_generated\\..+\\.go$"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some other generated file names without the zz_generated prefix, such as zz_controller.go or zz_register.go:

Suggested change
- "zz_generated\\..+\\.go$"
- "zz_\\..+\\.go$"

# ====================================================================================
# Setup Project

PROJECT_NAME ?= upjet-provider-template
PROJECT_REPO ?= github.com/upbound/$(PROJECT_NAME)
PROJECT_NAME := upjet-provider-template
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #30 for the rationale behind using ?= instead of :=:

Suggested change
PROJECT_NAME := upjet-provider-template
PROJECT_NAME ?= upjet-provider-template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants