Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build break from #862 #883

Closed
heaths opened this issue May 4, 2024 · 0 comments · Fixed by #888
Closed

Build break from #862 #883

heaths opened this issue May 4, 2024 · 0 comments · Fixed by #888

Comments

@heaths
Copy link
Contributor

heaths commented May 4, 2024

Describe the bug
Seems #862 broke the build by now always returning a result from <ModifierKeyCode as Display>::fmt. Also seems the #[cfg] attribute on the match itself isn't correct, as the individual match arms have conditions. Still, even without it still doesn't compile without some tweaks.

To Reproduce
Steps to reproduce the behavior:

  1. Try to build.

Expected behavior
Build fails with:

    |
922 |     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
    |        ---                                       ^^^^^^^^^^^ expected `Result<(), Error>`, found `()`
    |        |
    |        implicitly returns `()` as its body has no tail or `return` expression
    |
    = note:   expected enum `Result<(), std::fmt::Error>`
            found unit type `()`

OS

  • Any

Terminal/Console

  • Any
heaths added a commit to heaths/crossterm that referenced this issue May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant