feat(input): Add KeyEvent::Enter #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add KeyEvent::Enter. Also remove b'\r' from #[cfg(unix)], verify this is correct behavior.
TimonPost
approved these changes
Sep 19, 2019
|
I just realised, this is breaking change as matching KeyEvent::Char('\n') will no longer work, it would be the same for tab. I think I'm going to take a look at other libraries that provides enums for Keyboard input and look if there is more common key we should add. This way we could change it all in one go. |
|
Breaking change is fine, minor version will be bumped. There's a plan to release new crossterm by the end of this week / beginning of the next week. So, if you'd like to see more |
|
Jub release 0.11 will be the next one |
|
Nice ! I should have some time tommorow and this weekend 👍 |
december1981
pushed a commit
to december1981/crossterm
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add KeyEvent::Enter.
Also remove b'\r' from #[cfg(unix)] -> verify this is correct behavior.
Closes #234