Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetCursorStyle improvements #744

Merged
merged 3 commits into from
Jan 12, 2023
Merged

SetCursorStyle improvements #744

merged 3 commits into from
Jan 12, 2023

Conversation

Cl00e9ment
Copy link
Contributor

Followup to #742

  • Added a note to EnableBlinking and DisableBlinking to warn of cross-compatibility issues.
  • Removed "It uses two types of escape codes, one to control blinking, and the other the shape." because it's false. One escape code controls shape+blinking and the other was just a fall-back for blinking.
  • Removed the fall-back escape codes since during my tests on different terminals/OS a didn't find any occurrence were they would be needed.
  • Updated the doc.

@Cl00e9ment Cl00e9ment requested a review from TimonPost as a code owner January 11, 2023 20:34
TimonPost
TimonPost reviewed Jan 11, 2023
View reviewed changes
src/cursor.rs Show resolved Hide resolved
src/cursor.rs Show resolved Hide resolved
src/cursor.rs Show resolved Hide resolved
@TimonPost TimonPost merged commit fadec7a into crossterm-rs:master Jan 12, 2023
@TimonPost
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimonPost TimonPost TimonPost left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cl00e9ment @TimonPost