Fix examples on windows #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Some more notes: Wezterm eats key presses that are assigned to terminal shortcuts, but besides that it works perfectly along with conhost for KeyEventKind (press, release). While windows terminal shortcuts only apply while on the command line, yet it does not work correctly and keys that produce letters immediately send Created an issue for this here: microsoft/terminal#15124 |
This was referenced Apr 6, 2023
|
Great job, waiting for approvement! 🎉 |
TimonPost
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey so the examples/demos have been broken since I found this crate, this stops "double presses" from happening by only looking for presses instead of all events. It seems to make demos work in conhost, windows terminal, and wezterm.
Edit: the "release" event does not seem to appear on cmd, so the problem might not be crossterm and I removed this hack.
Fixes #759, closes #772, closes #769
Related issue: #752
Also I had a problem where rust-analyzer didn't work in the
interactive-demosub-crate, it just shows a message "file not included in module tree". I had to move the folder out of crossterm and change the path to it in order to make it work. I already tried a bunch of stuff like changing where I open the folder in helix etc. Anyone else have this?