Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window_size()
always returns an error on windows.WindowSize
.@markus-bauer this addresses some points of your comment in #790 after it was merged. What do you suggest regarding windows not being supported? I have tried everything in that regard:
(columns,rows)
. I doubt it would be precise or reliable.(columns,rows)
.GetClientRect
, which I almost thought would work, but even that gave me bogus values. Also seems a bit far off the track for a terminal library.Perhaps this was a mistake, and
window_size()
should be removed from crossterm, after all it's not cross-platform now. Users who need the window size, on unix, can then just use some tty-ioctl lib, e.g. rustix.My motivation was to make a library that can render images in the TUI apps, supporting sixels, kitty-graphics, or even ascii as fallback. It's necessary to know a character "cell" size in pixels to correctly up- or downscale an image into a given
(columns,rows)
area.