Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extra command in event-read example #894

Merged
merged 1 commit into from
Jun 16, 2024
Merged

fix: extra command in event-read example #894

merged 1 commit into from
Jun 16, 2024

Conversation

aschey
Copy link
Contributor

@aschey aschey commented May 21, 2024

Resolves #842

PopKeyboardEnhancementFlags is already called here with the proper check:

crossterm/examples/event-read.rs

Lines 100 to 102 in fce58c8

if supports_keyboard_enhancement {
queue!(stdout, PopKeyboardEnhancementFlags)?;
}
so we don't need to call it again.

@aschey aschey requested a review from TimonPost as a code owner May 21, 2024 04:53
@aschey aschey changed the title fix: extra command in fix event-read example fix: extra command in event-read example May 22, 2024
@TimonPost TimonPost merged commit be8cb8c into crossterm-rs:master Jun 16, 2024
@aschey aschey deleted the fix/event-example branch July 22, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimonPost TimonPost TimonPost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on Windows PowerShell with event-read example
2 participants
@aschey @TimonPost