-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cursor): Derive multiple traits for "SetCursorStyle" #909
feat(cursor): Derive multiple traits for "SetCursorStyle" #909
Conversation
I'm curious what use case there would be for ordering these? I can understand hashing them to store in some lookup table perhaps, but I can't think up a way that ordering them would be useful. |
I simply read other enums in this repo, and found most of them derives the But you're right, after a second thought, the Update: I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the comment about removing the tests.
Co-authored-by: Josh McKinney <joshka@users.noreply.github.com>
Update: accepted the suggestion. |
This comment was marked as resolved.
This comment was marked as resolved.
@linrongbin16 thanks - reported user, deleted comment. |
This PR derives multiple useful traits for
SetCursorStyle
enum:I checked other enums in
crossterm
, and seems they all have these traits. So I think it's ok to also add toSetCursorStyle
.It also adds 1 unit test to make sure they're working.