This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Android] Fix the crash of GetUserMedia #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing patch series with d73263b as its head.
|
|
@darktears @sqliu, PTAL. |
|
Is this a backport from upstream, or something that should have been upstreamed? |
|
Neither, it's a workaround of current P1 bug, which blocks the webrtc test. |
| @@ -236,8 +236,19 @@ AudioInputStream* AudioManagerAndroid::MakeLowLatencyInputStream( | |||
| DVLOG(1) << "Creating AudioRecordInputStream"; | |||
| return new AudioRecordInputStream(this, params); | |||
| } | |||
|
|
|||
| // TODO(xingnan): Crash will happen in the opensl library on some IA devices | |||
There was a problem hiding this comment.
It's openSL ES, http://www.khronos.org/opensles/
|
Testing patch series with dcf89f9 as its head.
|
|
Patch is updated as the comments, thanks. |
rakuco
pushed a commit
that referenced
this pull request
Jun 24, 2014
[Android] Fix the crash of GetUserMedia
|
Merged, remember to get this into v7 if necessary. |
|
definitely needed in v7 as well |
Crash happens when releasing the audio resource of localusermedia in openSL ES. On Android there are two ways to get the audio input: openSL ES and java Recording API. We swtich to the Recording API as a workaround of the bug. The limitation is Recording API only be avaiable after version 15 of SDK. BUG=XWALK-1833
|
Remember to bump |
xingnan
added a commit
to xingnan/crosswalk
that referenced
this pull request
Jun 25, 2014
darktears
pushed a commit
that referenced
this pull request
Sep 17, 2014
BUG=386454 R=manzagop@chromium.org, newt@chromium.org TBR=erikwright TEST=SuggestionsServiceTest Review URL: https://codereview.chromium.org/473123002 Cr-Commit-Position: refs/heads/master@{#291116} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291116 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit 1d1ab15) Review URL: https://codereview.chromium.org/527943002 Cr-Commit-Position: refs/branch-heads/2125@{#172} Cr-Branched-From: b68026d-refs/heads/master@{#290040}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
Was causing a bug where identities were slightly different. BUG=453792 Review URL: https://codereview.chromium.org/864223006 Cr-Commit-Position: refs/heads/master@{#313955} (cherry picked from commit ed8d517) Review URL: https://codereview.chromium.org/886233003 Cr-Commit-Position: refs/branch-heads/2272@{#172} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Apr 28, 2015
1. If the "suppress" checkbox was selected for a site, suppress beforeunload dialogs as well. 2. Re-enable dialogs only on cross-site navigation. BUG=473903 TEST=as in bug Review URL: https://codereview.chromium.org/1091073002 Cr-Commit-Position: refs/heads/master@{#325637} (cherry picked from commit 2460c76) TBR=ben@chromium.org Review URL: https://codereview.chromium.org/1089873005 Cr-Commit-Position: refs/branch-heads/2357@{#172} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
We need to get the correct favicon of the app or extension so that it's easier to identify in the table. Before and after screenshots are available on the BUG thread. TBR=nick@chromium.org,rdevlin.cronin@chromium.org BUG=525293 TEST=browser_tests --gtest_filter=ExtensionTagsTest.* Review URL: https://codereview.chromium.org/1302423005 Cr-Commit-Position: refs/heads/master@{#346155} (cherry picked from commit d91a619) Review URL: https://codereview.chromium.org/1303103005 . Cr-Commit-Position: refs/branch-heads/2490@{#172} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
BUG=566271 Review URL: https://codereview.chromium.org/1757103002 Cr-Commit-Position: refs/heads/master@{#379655} (cherry picked from commit 319c897) Review URL: https://codereview.chromium.org/1783833002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#172} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
…cations." > [DevTools] Flush when sending javascript dialog notifications. > > Notifications are sync IPCs, so we have to flush instead of > relying on task being finished. > > BUG=chromedriver:1381 > > Review-Url: https://codereview.chromium.org/2002223002 > Cr-Commit-Position: refs/heads/master@{#395465} (cherry picked from commit d876a64) TBR=samuong@chromium.org Review URL: https://codereview.chromium.org/2028313002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#172} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
Instead of having hard coded scale information on client side and send it back to wayland, which is basically the same information, the server sends the default dsf to client. Bug:64734914 Test: added unit test. Tested on 2x/1.25x devices with ARC++ side changes. (cherry picked from commit b61a264) Reviewed-on: https://chromium-review.googlesource.com/646026 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499225} Change-Id: I61654e5d218676c12f53986a00755145771f697b Reviewed-on: https://chromium-review.googlesource.com/663421 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#172} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crash happens when releasing the audio resource of localusermedia in
opensl. On Android there are two ways to get the audio input: opensl
and java Recording API. We swtich to the Recording API as a workaroud
of the bug. The limitation is Recording API only be avaiable after
version 15 of SDK.
BUG=XWALK-1833