This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Android] Fix the crash of GetUserMedia #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakuco
pushed a commit
that referenced
this pull request
Jun 24, 2014
[Android] Fix the crash of GetUserMedia
Crash happens when releasing the audio resource of localusermedia in openSL ES. On Android there are two ways to get the audio input: openSL ES and java Recording API. We swtich to the Recording API as a workaround of the bug. The limitation is Recording API only be avaiable after version 15 of SDK. BUG=XWALK-1833 Cherry picked from commit dcf89f9
darktears
pushed a commit
that referenced
this pull request
Sep 17, 2014
The crash was caused by a dangling pointer to a deleted observer registered by MostVisitedSites. BUG=406996 Review URL: https://codereview.chromium.org/501973004 Cr-Commit-Position: refs/heads/master@{#292034} (cherry picked from commit 94a4210) Review URL: https://codereview.chromium.org/533663002 Cr-Commit-Position: refs/branch-heads/2125@{#173} Cr-Branched-From: b68026d-refs/heads/master@{#290040}
darktears
pushed a commit
that referenced
this pull request
Nov 17, 2014
BUG=421466 TEST=manual Review URL: https://codereview.chromium.org/646823002 Cr-Commit-Position: refs/heads/master@{#299562} (cherry picked from commit 86c076c) TBR=xiyuan@chromium.org Review URL: https://codereview.chromium.org/659273003 Cr-Commit-Position: refs/branch-heads/2171@{#173} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
This tells the plugin not to handle middle-click events so that they are properly handled by the container page and allows middle-click scrolling to work. BUG=463399 Review URL: https://codereview.chromium.org/976123002 Cr-Commit-Position: refs/heads/master@{#319366} (cherry picked from commit 78a82c8) Review URL: https://codereview.chromium.org/990043002 Cr-Commit-Position: refs/branch-heads/2311@{#173} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Apr 28, 2015
Allow the "prevent additional dialogs" checkbox button to appear on beforeunload dialogs. BUG=473903 TEST=Repeated beforeunload dialogs show a suppression checkbox Review URL: https://codereview.chromium.org/1092123002 Cr-Commit-Position: refs/heads/master@{#325726} (cherry picked from commit 86578a8) TBR=ben@chromium.org Review URL: https://codereview.chromium.org/1098993002 Cr-Commit-Position: refs/branch-heads/2357@{#173} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
The ChildProcessTask used to skip using the process name when localizing the the title for utility processes. This patch is fixing this. TBR=nick@chromium.org BUG=524286 Review URL: https://codereview.chromium.org/1310443006 Cr-Commit-Position: refs/heads/master@{#345364} (cherry picked from commit cf56bd0) Review URL: https://codereview.chromium.org/1318663006 . Cr-Commit-Position: refs/branch-heads/2490@{#173} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
The Galaxy XCover 3 (SM-G388F, K, ES3) has incorrect colors on images with GPU raster in M47. I tested blacklisting GPU raster fixes the issue. BUG=560587 Review URL: https://codereview.chromium.org/1478623002 Cr-Commit-Position: refs/heads/master@{#361720} (cherry picked from commit c645adb) Review URL: https://codereview.chromium.org/1491513003 . Cr-Commit-Position: refs/branch-heads/2564@{#173} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
If we return nullptr trying to consume a compound, and all tokens have been consumed, we don't recognize that as a parse failure if a valid selector precedes the compound. Set m_failedParsing to true to notice we have an invalid selector. R=timloh@chromium.org BUG=581257 Review URL: https://codereview.chromium.org/1634273003 Cr-Commit-Position: refs/heads/master@{#371760} (cherry picked from commit acce413) Review URL: https://codereview.chromium.org/1641673004 . Cr-Commit-Position: refs/branch-heads/2623@{#173} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
Failing to do so results in several bugs: - The save card icon sometimes fails to appear. - The cursor rect for the omnibox isn't updated, resulting in the wrong mouse icon being shown when hovering over the save card icon. - The save card icon tooltip doesn't appear. BUG=566271 Review URL: https://codereview.chromium.org/1760273002 Cr-Commit-Position: refs/heads/master@{#379629} (cherry picked from commit dff48ce) Review URL: https://codereview.chromium.org/1783693003 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#173} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Change from 50% alpha to 60% alpha as starting point (as per sgabriel's recommendation). Add a second step where we calculate a readable color. This doesn't affect the classic theme but makes the text a little darker in some cases (like GTK mode). BUG=615175 Review-Url: https://codereview.chromium.org/2018023002 Cr-Commit-Position: refs/heads/master@{#396522} (cherry picked from commit 480bd20) Review URL: https://codereview.chromium.org/2036443002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#173} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
Increased the precision in case we want to use 3 digit decimal scale factor (like 1.825) without error. (cherry picked from commit 40405e1) Bug: b/62452570 Test: None Change-Id: I8d8ff34a32089a0fa8d027cdc09f128b2c3d6e4b Reviewed-on: https://chromium-review.googlesource.com/652962 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500077} Reviewed-on: https://chromium-review.googlesource.com/663633 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#173} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crash happens when releasing the audio resource of localusermedia in
openSL ES. On Android there are two ways to get the audio input:
openSL ES and java Recording API. We swtich to the Recording API as a
workaround of the bug. The limitation is Recording API only be avaiable
after version 15 of SDK.
BUG=XWALK-1833
Cherry picked from commit dcf89f9