This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Android] Cherry-pick r278950 (0e40ce9) from upstream #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: mnaganov@chromium.org Disable ChildTraceMessageFilter in single process mode This fixes chrome://inspect traces for Android WebView. ChildTraceMessageFilter instances are all talking to the same TraceLog instance and confuse it. Enabling tracing in browser is enough, since everyone lives in the same process. Review URL: https://codereview.chromium.org/349633003 BUG=XWALK-1571
|
@rakuco It's cherry-picked from master, and enable tracing in single process mode. |
rakuco
pushed a commit
that referenced
this pull request
Jul 1, 2014
[Android] Cherry-pick r278950 (0e40ce9) from upstream
darktears
pushed a commit
that referenced
this pull request
Sep 17, 2014
Crash reports indicate that the WindowAndroid's Compositor may be NULL during |RenderWidgetHostViewAndroid::SetContentViewCore()|. While this is a somewhat surprising result, it is in theory possible and should probably not be fatal. Avoid creating the overscroll effect in this case, instead creating it after the compositor is (re-)attached. BUG=407208 TBR=aelias@chromium.org,sievers@chromium.org Review URL: https://codereview.chromium.org/503813003 Cr-Commit-Position: refs/heads/master@{#291835} (cherry picked from commit 7936233) Review URL: https://codereview.chromium.org/532733002 Cr-Commit-Position: refs/branch-heads/2125@{#175} Cr-Branched-From: b68026d-refs/heads/master@{#290040}
darktears
pushed a commit
that referenced
this pull request
Nov 17, 2014
BUG=422006 TBR=tedchoc@chromium.org Review URL: https://codereview.chromium.org/658523005 Cr-Commit-Position: refs/heads/master@{#299725} Review URL: https://codereview.chromium.org/658423003 Cr-Commit-Position: refs/branch-heads/2171@{#175} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
Pipe DidStartNavigationToPendingEntry to WebContentsObserver and TabObserver. BUG=442726 Review URL: https://codereview.chromium.org/877163005 Cr-Commit-Position: refs/heads/master@{#313866} (cherry picked from commit 4bd261a) Review URL: https://codereview.chromium.org/890223002 Cr-Commit-Position: refs/branch-heads/2272@{#175} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
…lable width. BUG=463853 TEST=Confirm that the breadcrumbs is properly truncated when window is narrowed or the number of toolbar buttons is changed. TBR=hirono@chromium.org Review URL: https://codereview.chromium.org/984873002 Cr-Commit-Position: refs/heads/master@{#319430} (cherry picked from commit 2e51b89) Review URL: https://codereview.chromium.org/983363002 Cr-Commit-Position: refs/branch-heads/2311@{#175} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Apr 28, 2015
This replaces percent-encoding whitespace as a method to combat the use of crafted URL fragments to inject messages into the page info popup. By truncating the URL so that at most two lines of the fragment are shown, we prevent lengthy messages from being injected while minimising the effect on most URLs. BUG=466351 Review URL: https://codereview.chromium.org/1077483002 Merged from trunk. TBR=tedchoc@chromium.org Cr-Commit-Position: refs/heads/master@{#325358} (cherry picked from commit 5bf8a2d) Review URL: https://codereview.chromium.org/1061533006 Cr-Commit-Position: refs/branch-heads/2357@{#175} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
…plication is being stopped already. BUG=562672 Sometimes the client sends the STOP command while the Cast application has disconnected but Chrome is still updating its state. In this case, respond to the client with the success message and matching sequence number. Review URL: https://codereview.chromium.org/1479303002 Cr-Commit-Position: refs/heads/master@{#362233} (cherry picked from commit dbd6927) Review URL: https://codereview.chromium.org/1490773002 . Cr-Commit-Position: refs/branch-heads/2564@{#175} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
This CL does two things: - It limits the size of poster bitmaps used by Cast to 1024*1024 - It delays getting the poster bitmap until it is actually needed, and disposes of bitmaps when Cast has finished with them. This means that there should never be more than one poster bitmap in memory at a time (although there may be C++ and Java copies of it.). This should drastically reduce the number of OOM crashes we get from poster bitmaps. BUG=529871 Review URL: https://codereview.chromium.org/1634173002 Cr-Commit-Position: refs/heads/master@{#371541} (cherry picked from commit fee9a5e) Review URL: https://codereview.chromium.org/1641643003 . Cr-Commit-Position: refs/branch-heads/2623@{#175} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
Adds starting margin to entry div so that the favicon is not flush with the timestamp. BUG=580336 Review URL: https://codereview.chromium.org/1778493003 Cr-Commit-Position: refs/heads/master@{#380142} (cherry picked from commit 7d25f6e) Review URL: https://codereview.chromium.org/1779883003 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#175} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Only lock the shelf once the lock animation starts. (do not lock earlier, on the pre-lock animation start) Add Alt-L (Lock) and Alt-P (Power) --ash-debug-shortcuts. BUG=614042 TEST=Quickly tapping power/lock doesn't lock the shelf. R=oshima@chromium.org Review-Url: https://codereview.chromium.org/2013933002 Cr-Commit-Position: refs/heads/master@{#396599} (cherry picked from commit dbd0521) Review URL: https://codereview.chromium.org/2035483002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#175} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
The renderer SurfaceLayer and some other Surface related information wasn't always being cleared when the gpu restarted. Ensure that happens. Bug: 761131 Change-Id: I4c53d4f0ec288bf8bf9cee32af1174caa8256f4b Reviewed-on: https://chromium-review.googlesource.com/646515 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499256}(cherry picked from commit ac4bbf4) Reviewed-on: https://chromium-review.googlesource.com/663478 Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#175} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: mnaganov@chromium.org
Disable ChildTraceMessageFilter in single process mode
This fixes chrome://inspect traces for Android WebView.
ChildTraceMessageFilter instances are all talking to the same TraceLog
instance and confuse it. Enabling tracing in browser is enough, since
everyone lives in the same process.
Review URL: https://codereview.chromium.org/349633003
BUG=XWALK-1571