Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

DO NOT MERGE: Exercise the content shell bots. #176

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE: Exercise the content shell bots. #176

wants to merge 1 commit into from

Conversation

rakuco
Copy link

@rakuco rakuco commented Jul 3, 2014

Let's see if they migrate to git correctly.

@crosswalk-trybot
Copy link

Testing patch series with 8be3291 as its head.

Bot Status
Content Shell Linux [FAILED 💔](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/96)
Content Shell Android-x86 [FAILED 💔](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/95)

@crosswalk-trybot
Copy link

Testing patch series with b3a1ba3 as its head.

Bot Status
Content Shell Android-x86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/96)
Content Shell Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/97)

@crosswalk-trybot
Copy link

Testing patch series with 68a0ecb as its head.

Bot Status
Content Shell Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/98)
Content Shell Android-x86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/97)

DO NOT MERGE: Exercise the content shell bots.
68a0ecb 
Let's see if they migrate to git correctly.
@rakuco rakuco closed this Jul 8, 2014
@rakuco rakuco deleted the test-content-shell-builders branch July 8, 2014 13:32
darktears pushed a commit that referenced this pull request Sep 17, 2014
[Android] Clear backing SkBitmap before rendering the overscroll effect
61a2edc 
Skia makes no guarantees about the contents of a newly allocated
SkBitmap. Consequently, it's possible that the bitmap allocated for the
overscroll effect isn't zeroed before the effect itself is painted.
Prevent related issues by always clearing the allocated SkBitmap's
contents (to fully transparent) before painting the effect.

BUG=408225
TBR=aelias@chromium.org

Review URL: https://codereview.chromium.org/484373004

Cr-Commit-Position: refs/heads/master@{#292280}
(cherry picked from commit 46c0ec3)

Review URL: https://codereview.chromium.org/527363002

Cr-Commit-Position: refs/branch-heads/2125@{#176}
Cr-Branched-From: b68026d-refs/heads/master@{#290040}
darktears pushed a commit that referenced this pull request Nov 17, 2014
Remove the Relaunch into Chrome immersive mode for Windows 7 for M39
e3d5959 
BUG=356475
R=cpu@chromium.org
TBR=sky

Review URL: https://codereview.chromium.org/666473005

Cr-Commit-Position: refs/branch-heads/2171@{#176}
Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco pushed a commit that referenced this pull request Feb 27, 2015
Incrementing VERSION to 41.0.2272.41
183e838 
Cr-Commit-Position: refs/branch-heads/2272@{#176}
Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco pushed a commit that referenced this pull request Mar 12, 2015
Files.app: Remove focus from toolbar buttons on click.
c735243 
BUG=461669
TEST=manually tested
TBR=yawano@chromium.org

Review URL: https://codereview.chromium.org/984823002

Cr-Commit-Position: refs/heads/master@{#319419}
(cherry picked from commit f2e381e)

Review URL: https://codereview.chromium.org/983383002

Cr-Commit-Position: refs/branch-heads/2311@{#176}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco pushed a commit that referenced this pull request Apr 28, 2015
branch 2357: Fix leak from android Context
e9e41f7 
The Activity, which is normally the Context instance, holds the view
tree, which in turns can prevent native side from garbage collected. So
native code cannot hold strongly to the Context object.

There are two instances where Context is leaking:

1) Currently native holds ContentViewAndroidDelegate which holds
the Context. Stop holding the Context and just use get the context
for the container view, which is already held weakly.

This means acquireAnchorView can return null when the java peer
has been garbage collected, but native side has not been destroyed
yet. This is never a problem in chrome. This happens to not be a
problem in webview, because all callers of acquireAnchorView already
guarantees the ContentViewCore is still alive.

2) CaptionManager uses the Context (instead of Application Context)
and never unregisters it in WebView. This keeps a dangling reference
all the way to the Context used to register in Android framework
code.

In this CL, only fix the webview leak by using the Application Context.
There is still the problem that the CaptionManager is unregistered
which will be fixed in the future.

Modify the webview gc test to catch this case.

BUG=478719, 469803

Review URL: https://codereview.chromium.org/1092323002

Cr-Commit-Position: refs/heads/master@{#325961}
(cherry picked from commit 157d438)
TBR=boliu@chromium.org

Review URL: https://codereview.chromium.org/1050823005

Cr-Commit-Position: refs/branch-heads/2357@{#176}
Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk pushed a commit that referenced this pull request Sep 22, 2015
Plugins: Always mark plugins within Chrome Apps <webview> as Unauthor…
19db8c0 
…ized.

Previously, they were marked as Unauthorized only when they were set as ALLOW
in Content Settings. This created a (small?) security issue when Plugins were
marked as DETECT or BLOCK.

BUG=527620

Review URL: https://codereview.chromium.org/1325163002

Cr-Commit-Position: refs/heads/master@{#347241}
(cherry picked from commit 550b222)

Review URL: https://codereview.chromium.org/1308793006 .

Cr-Commit-Position: refs/branch-heads/2490@{#176}
Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk pushed a commit that referenced this pull request Dec 18, 2015
@thiemonagel
Disable Public Session auto-whitelisting.
8578d1e 
R48 launch was not approved.  This CL will be reverted after it has
been merged to the R48 branch.

BUG=470779

Review URL: https://codereview.chromium.org/1480633002

Cr-Commit-Position: refs/heads/master@{#361975}
(cherry picked from commit e8cef80)

Review URL: https://codereview.chromium.org/1487013002 .

Cr-Commit-Position: refs/branch-heads/2564@{#176}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco pushed a commit that referenced this pull request Mar 3, 2016
Don't try to use ManagePasswordsBubbleModel if the password bubble wa…
325f3c2 
…s closed.

The bubble may be closed by some navigation in the content area. However, if the user pressed a button before closing and released after then the button action is still sent. Moreover, all the objects like NSWindow, NSWindowController, NSViewController are still alive. The UI code should not ping ManagePasswordsBubbleModel which is actually destroyed.

BUG=579726

Review URL: https://codereview.chromium.org/1637043002

Cr-Commit-Position: refs/heads/master@{#371513}
(cherry picked from commit a3aaa89)

Review URL: https://codereview.chromium.org/1648533003 .

Cr-Commit-Position: refs/branch-heads/2623@{#176}
Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request May 17, 2016
Check for self in WebUIManager block
bd26ca9 
Putative fix for crash in WebUIManager. Checks that self has not been
deallocated before getting webState and executing JavaScript.

BUG=579682

Review URL: https://codereview.chromium.org/1779433006

Cr-Commit-Position: refs/heads/master@{#380189}
(cherry picked from commit c4c53a5)

Review URL: https://codereview.chromium.org/1785733002 .

Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#176}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request Oct 9, 2016
@btolsch
[Media Router WebUI] Update element positioning after delayed imports.
36c6f4a 
This change adds a call to update the positioning of dialog elements
after the delayed html imports have finished. Delaying the imports seems
to cause the first run flow element (which is conditionally templated)
to have an offsetHeight of 0 after it is stamped but before the imports
complete. Adding another update call lets the update correctly see this
element's offsetHeight when it is supposed to be visible.

R=apacible@chromium.org
BUG=612726
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1996233002
Cr-Commit-Position: refs/heads/master@{#395116}
(cherry picked from commit 2786224)

Review-Url: https://codereview.chromium.org/2029783002
Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#176}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
@pimanttr
Create GrGLInterface based on ui/gl's bindings instead of GrGLAssembl…
e1d0262 
…eGLInterface

GrGLAssembleGLInterface is a lot of code to lookup GL function pointers,
which is somewhat duplicated in ui/gl's bindings. This saves about 21kb
on Android.

Bug: 760250
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I906997ab8cc03db06a437d3428ca4263b13d2025
Reviewed-on: https://chromium-review.googlesource.com/646957
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499293}(cherry picked from commit 148d059)
Reviewed-on: https://chromium-review.googlesource.com/663669
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#176}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakuco @crosswalk-trybot