This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
DO NOT MERGE: trybot test #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing some custom landmines.
|
Testing patch series with 717015a as its head.
|
darktears
pushed a commit
that referenced
this pull request
Sep 17, 2014
Currently, if |compositor_needs_continuous_invalidate_| is unset before PostFallbackTick or FallbackTickFired, then the fallback ticks are cancelled, but we never unset |block_invalidates_|, which will block invalidates indefinitely. Fix is simply always unset |block_invalidates_| even if we skip the fallback tick. BUG=408779 Review URL: https://codereview.chromium.org/512403002 Cr-Commit-Position: refs/heads/master@{#292511} (cherry picked from commit d3ba720) TBR=boliu@chromium.org Review URL: https://codereview.chromium.org/528953003 Cr-Commit-Position: refs/branch-heads/2125@{#177} Cr-Branched-From: b68026d-refs/heads/master@{#290040}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
BUG=449075 TEST=content_unittests --gtest_filter=NavigationControllerTest.IsInPageNavigation Review URL: https://codereview.chromium.org/855883002 Cr-Commit-Position: refs/heads/master@{#313051} (cherry picked from commit 3d42643) TBR=creis@chromium.org Review URL: https://codereview.chromium.org/895463003 Cr-Commit-Position: refs/branch-heads/2272@{#177} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
This fixes the browser crash that happens when ServiceWorkerContextCore has no live registration corresponding to the live version. This is a quick fix intended to be mergeable. BUG=459916 Review URL: https://codereview.chromium.org/982743002 Cr-Commit-Position: refs/heads/master@{#319214} (cherry picked from commit d8905bf) TBR=kinuko@chromium.org Review URL: https://codereview.chromium.org/991633003 Cr-Commit-Position: refs/branch-heads/2311@{#177} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Apr 28, 2015
> [DevTools] Disable emulation on DevTools itself. > > BUG=478051 > > Review URL: https://codereview.chromium.org/1062733006 > Cr-Commit-Position: refs/heads/master@{#325628} TBR=pfeldman Review URL: https://codereview.chromium.org/1100573003 Cr-Commit-Position: refs/branch-heads/2357@{#177} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
…emoved. BUG=359315 Review URL: https://codereview.chromium.org/1473673003 Cr-Commit-Position: refs/heads/master@{#361626} (cherry picked from commit 40cb474) Review URL: https://codereview.chromium.org/1486893003 . Cr-Commit-Position: refs/branch-heads/2564@{#177} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
…interruption. DownloadFileImpl/BaseFile was causing the SecureHash object to be finalized when a download was interrupted. This caused the hash state to be incorrect and subsequently the hash resulting from resuming the download was also incorrect. BUG=7648 BUG=581164 Review URL: https://codereview.chromium.org/1591523002 Cr-Commit-Position: refs/heads/master@{#371428} (cherry picked from commit bdc7250) Review URL: https://codereview.chromium.org/1648683002 . Cr-Commit-Position: refs/branch-heads/2623@{#177} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
BUG=593380 Review URL: https://codereview.chromium.org/1780683002 Cr-Commit-Position: refs/heads/master@{#380164} (cherry picked from commit c1e26c7) Review URL: https://codereview.chromium.org/1778423002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#177} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
This change gives the search div tag a z-index so that the mouse can interact with it when the search results are being shown, which currently cover the search div with padding. BUG=615284 R=apacible@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2019543002 Cr-Commit-Position: refs/heads/master@{#396414} (cherry picked from commit c93f386) Review-Url: https://codereview.chromium.org/2035473002 Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#177} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
…ings - ExtensionSet is just a flat_map of StringPiece's. After construction, we only look up into ExtensionSet, so a flat map is ideal. Using StringPiece avoids copies. - Remove GLContext::GetExtensions platform overrides. They used to add WGL/GLX/EGL extensions to the GL extension string, but we never test for them in that path (i.e. that's pure overhead). If we need to expose them in the future, a separate function would be preferable. - Have GLContext::GetExtensions compute, cache, and return the ExtensionSet. This avoids extraneous string manipulations (split/join) and copies. As a side effect, bindings now lookup the actual extension string as opposed to adding a space after it. This allows sharing the string with other places we test for those extensions. It also makes the bindings initialization code much more efficient. About 15Kb saved on Android. Bug: 760250 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If830612ca7e23f705808c7b0908322671553122c Reviewed-on: https://chromium-review.googlesource.com/648244 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499783}(cherry picked from commit 20d1620) Reviewed-on: https://chromium-review.googlesource.com/663883 Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#177} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing some custom landmines.