This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Android] Implement ScreenOrientation.unlock align with spec #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for compliance with ScreenOrientation (https://w3c.github.io/screen-orientation). When unlock screen orientation, it should lock the orientation to default orientation. Previous implementation is to set the orientation to "unspecified", which is not fully aligned with spec. Instead, read the configuration from the activity metadata in AndroidManifest.xml and set the orientation accordingly. BUG=394214 Review URL: https://codereview.chromium.org/399553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284396 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit 11420f5)
|
Testing patch series with 13884df as its head.
|
|
It's a backport from upstream, @kenchris @darktears , please help review, thanks. |
|
Looks OK to me. Is this something that's OK to have only after the M37 rebase (ie. it wasn't broken or didn't matter before)? |
It should be applicable for all base after the baseline of screenOrientation implmentation is included. |
rakuco
pushed a commit
that referenced
this pull request
Jul 28, 2014
[Android] Implement ScreenOrientation.unlock align with spec
|
Merged, please make sure to backport it to v7 if applicable. |
darktears
pushed a commit
that referenced
this pull request
Sep 17, 2014
BUG=405784 Review URL: https://codereview.chromium.org/502103003 Cr-Commit-Position: refs/heads/master@{#291908} (cherry picked from commit aea4a57) Review URL: https://codereview.chromium.org/531843002 Cr-Commit-Position: refs/branch-heads/2125@{#178} Cr-Branched-From: b68026d-refs/heads/master@{#290040}
darktears
pushed a commit
that referenced
this pull request
Nov 17, 2014
> BUG=419883 > > Review URL: https://codereview.chromium.org/639913002 > > Cr-Commit-Position: refs/heads/master@{#298912} > (cherry picked from commit 5eb3ae1) > > Fix a startup crash from https://crrev.com/5eb3ae10901fa65657abc902910265ab492c5dbf > > EasyUnlockKeymanager is not initialized when UpdateEasyUnlockKeys is called > from FinalizePrepareProfile > > BUG=419883,422102 > > Review URL: https://codereview.chromium.org/642153003 > > Cr-Commit-Position: refs/heads/master@{#299024} > (cherry picked from commit dec9a7f) TBR=xiyuan@chromium.org Review URL: https://codereview.chromium.org/661113003 Cr-Commit-Position: refs/branch-heads/2171@{#178} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
When "Choose what to sync" is clicked, we change the source to 3 in the gaia continue url. BUG=452440 TBR=noms@chromium.org Review URL: https://codereview.chromium.org/892493002 (cherry picked from commit ef953dd) Review URL: https://codereview.chromium.org/899433002 Cr-Commit-Position: refs/branch-heads/2272@{#178} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
PasswordManagerBrowserTest.NoPromptOnBack got merged into 2311 by accident in https://codereview.chromium.org/978363004/. That CL merged https://codereview.chromium.org/944163003 into 2311, but 944163003 did not add NoPromptOnBack to trunk. NoPromptOnBack was added in https://codereview.chromium.org/902893003, which is not present in 2311. As a result, the mis-merged NoPromptOnBack started failing immediately (lacking some support files, as well as the actual fix for the tested issue). TBR=gcasto@chromium.org,amineer@chromium.org BUG=465219 Review URL: https://codereview.chromium.org/990853002 Cr-Commit-Position: refs/branch-heads/2311@{#178} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
WKWebView throws an exception if didReceiveAuthenticationChallenge's completion handler is deallocated w/o being called. This call happen during shut down, when posted IO/Worker tasks will not start. To address that problem CRWCertVerificationController must guarantee that its completion handlers are always called. Since every completion handler is wrapped into BlockHolder, holder will make sure that handlers are always called before deallocation. BUG=557828 Review URL: https://codereview.chromium.org/1459763002 Cr-Commit-Position: refs/heads/master@{#361768} (cherry picked from commit 3d82ac5) Review URL: https://codereview.chromium.org/1487023002 . Cr-Commit-Position: refs/branch-heads/2564@{#178} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
…oth PHONE_HOME_CITY_AND_NUMBER and PHONE_HOME_WHOLE_NUMBER are matched, it means there is no country code in the profile's phone number. In that case, only match PHONE_HOME_CITY_AND_NUMBER because it's more precise. BUG=580629 TEST=AutofillManagerTest Review URL: https://codereview.chromium.org/1623803002 Cr-Commit-Position: refs/heads/master@{#371867} (cherry picked from commit 03c71f5) Review URL: https://codereview.chromium.org/1646533006 . Cr-Commit-Position: refs/branch-heads/2623@{#178} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
Previously direct load cancellations were simply discarded. Calling loadCancelled ensures that the delegate is notified of the cancellation. BUG=562501 Review URL: https://codereview.chromium.org/1775403004 Cr-Commit-Position: refs/heads/master@{#380261} (cherry picked from commit 727c225) Review URL: https://codereview.chromium.org/1780263002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#178} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
This change corrects the point of setting the search focus handlers to be after search first becomes enabled. Previously it was set in ready(), but since disabling search by default, the handlers weren't correctly updated. BUG=592723 R=apacible@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2012593002 Cr-Commit-Position: refs/heads/master@{#395774} (cherry picked from commit e5e7577) Review-Url: https://codereview.chromium.org/2033473002 Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#178} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
We've run into a host of issues where compositor updates are required to get the controls into the correct state, so that restoring them doesn't fail. This CL delays pausing VSync until the controls have been properly hidden when entering VR. Bug: 760970 Change-Id: I9a80709e58d0588d456d8cbb1e6d9ede84ff6a3f Reviewed-on: https://chromium-review.googlesource.com/645828 Reviewed-by: Biao She <bshe@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500067}(cherry picked from commit b8c7f90) Reviewed-on: https://chromium-review.googlesource.com/663279 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#178} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for compliance with ScreenOrientation
(https://w3c.github.io/screen-orientation).
When unlock screen orientation, it should lock the orientation
to default orientation.
Previous implementation is to set the orientation to "unspecified",
which is not fully aligned with spec.
Instead, read the configuration from the activity metadata in
AndroidManifest.xml and set the orientation accordingly.
BUG=394214
Review URL: https://codereview.chromium.org/399553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284396 0039d316-1c4b-4281-b951-d872f2087c98
(cherry picked from commit 11420f5)