This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 211
[Temp][Tizen] Temporarily remove ozone dependency for gl #180
Merged
rakuco
merged 1 commit into
crosswalk-project:master
from
qjia7:remove_ozone_dependency
Jul 28, 2014
Merged
[Temp][Tizen] Temporarily remove ozone dependency for gl #180
rakuco
merged 1 commit into
crosswalk-project:master
from
qjia7:remove_ozone_dependency
Jul 28, 2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing patch series with e37d5a6 as its head.
|
rakuco
pushed a commit
that referenced
this pull request
Jul 28, 2014
[Temp][Tizen] Temporarily remove ozone dependency for gl
I've merged the pull request, but I want the "[Temp]" in the title to actually mean it's a temporary patch -- please talk to upstream and find a solution to this problem that doesn't need a custom patch on our side. |
Currently, the ozone-wayland depends on ui/gl. However, that will cause cycling dependency error. So temporarily remove ozone dependency for gl until we find a better way. Refer to intel/ozone-wayland#240 and intel/ozone-wayland#246
darktears
pushed a commit
that referenced
this pull request
Sep 17, 2014
- On tablets the new anchor point was 6dp off due to the new shadow assets. To fix this add a 6dp translate to the enter animation that will move the asset into the correct location as the scale animation runs. This effectively mimics the old animation but allows the offset to be included. BUG=405352 Review URL: https://codereview.chromium.org/488863002 Cr-Commit-Position: refs/heads/master@{#290773} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290773 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit 6f2a9c8) Review URL: https://codereview.chromium.org/533813002 Cr-Commit-Position: refs/branch-heads/2125@{#180} Cr-Branched-From: b68026d-refs/heads/master@{#290040}
darktears
pushed a commit
that referenced
this pull request
Nov 17, 2014
VEA supported profiles are added to GPUInfo when GPU process starts. But the video devices are not ready yet at that time. We need a low risk way to fix this in M39. Make V4L2VEA GetSupportedProfiles static so we can merge it back to M39. This will be fixed later in a proper way. BUG=418762 TEST=Reboot on peach pit and run apprtc loopback. TBR=posciak@chromium.org Review URL: https://codereview.chromium.org/650183002 Cr-Commit-Position: refs/heads/master@{#299453} (cherry picked from commit 8396651) Review URL: https://codereview.chromium.org/665703003 Cr-Commit-Position: refs/branch-heads/2171@{#180} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
If the profile is NULL, the code will hit the CHECK on line 389 anyway. BUG=414332 TBR=noms@chromium.org Review URL: https://codereview.chromium.org/878143003 Cr-Commit-Position: refs/heads/master@{#313709} (cherry picked from commit 82e87d5) Review URL: https://codereview.chromium.org/897453002 Cr-Commit-Position: refs/branch-heads/2272@{#180} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
If the scheduler's closure is synchronous it can wind up popping its callback from the queue (causing the closure to be deleted if it's the last reference) while the callback is running. If the closure holds a refptr that owns the scheduler, bad things happen. The fix is to hold a reference to the closure while it's running. To make the scheduler a bit easier to read, rather than pop the queue after the operation completes, it now pops it before running the operation. BUG=463782 TBR=michaeln@chromium.org Review URL: https://codereview.chromium.org/978383003 Cr-Commit-Position: refs/heads/master@{#319381} (cherry picked from commit 9f1cb7c) Review URL: https://codereview.chromium.org/990213002 Cr-Commit-Position: refs/branch-heads/2311@{#180} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Apr 28, 2015
BUG=431057,442173 Review URL: https://codereview.chromium.org/1008473006 Cr-Commit-Position: refs/heads/master@{#325382} (cherry picked from commit 43b2a12) Review URL: https://codereview.chromium.org/1100763003 Cr-Commit-Position: refs/branch-heads/2357@{#180} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
The metric added in https://codereview.chromium.org/1259953003 is measured in BrowsingDataRemover, and includes deletions initiatied from anywhere. This new metric focuses specifically on deletions initiated from the Clear Browsing Data dialog. BUG=527372 Review URL: https://codereview.chromium.org/1325083002 Cr-Commit-Position: refs/heads/master@{#347275} (cherry picked from commit c927f52) TBR=markusheintz@chromium.org,asvitkine@chromium.org,estade@chromium.org Review URL: https://codereview.chromium.org/1328113003 . Cr-Commit-Position: refs/branch-heads/2490@{#180} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
Integrating the unicode compatibility decomposition and shaping of whitespace fixes. BUG=558707 R=eae,kojii,behdad Review URL: https://codereview.chromium.org/1476763003 Cr-Commit-Position: refs/heads/master@{#362116} (cherry picked from commit c3c69f0) Review URL: https://codereview.chromium.org/1492433002 . Cr-Commit-Position: refs/branch-heads/2564@{#180} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
BUG=582194 TEST=Tested with local test and makes sure the certificate is passed from JS to MediaDrm. Review URL: https://codereview.chromium.org/1648073002 Cr-Commit-Position: refs/heads/master@{#372195} (cherry picked from commit adf457d) Review URL: https://codereview.chromium.org/1645813003 . Cr-Commit-Position: refs/branch-heads/2623@{#180} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
Chrome on iOS is aligning with the rest of Chrome and no longer uses "ios_extra_version_path". Remove it from version_info components and remove the "gclient" hook that generated ios/build/util/CANARY_VERSION. BUG=591419 Review URL: https://codereview.chromium.org/1784783002 Cr-Commit-Position: refs/heads/master@{#380394} (cherry picked from commit 39e8a6f) Review URL: https://codereview.chromium.org/1784563003 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#180} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
This change ensures that a call to putSearchAtBottom_() is made after all the html imports have been completed. This should ensure that the reference to search.offsetHeight is not zero when it sets margins and padding. BUG=614209, 609350 R=apacible@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2008393002 Cr-Commit-Position: refs/heads/master@{#396244} (cherry picked from commit 39dfd06) Review-Url: https://codereview.chromium.org/2028373002 Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#180} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
The animation logic in the progress bar has no dependencies since it has launched (previously depended on native flags). This change moves the animation init to the progress bar constructor so it is always available. BUG=761051 TBR=mdjones@chromium.org (cherry picked from commit 3b93fa9) Change-Id: If59215a669db64be07c55f4dd19ca893d8af823f Reviewed-on: https://chromium-review.googlesource.com/646696 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499224} Reviewed-on: https://chromium-review.googlesource.com/663782 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#180} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ozone-wayland depends on ui/gl. However, that will cause cycling
dependency error. So temporarily remove ozone dependency for gl until we find a
better way.
Refer to intel/ozone-wayland#240 and
intel/ozone-wayland#246