This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Temp] Roll ANGLE to 5ac2ae3ea1f311be61955b2d554e8510474cf4f0. #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually advance the ANGLE checkout one commit ahead in its
chromium/2062 to grab the fix its bug 669 ("Build started depending on
.git/").
This is required for a build from a tarball to work, and allows us to
remove our manual workaround from the Tizen packaging.
The roll upstream will be part of more recent M37 releases.
|
Testing patch series with ab6d5f1 as its head.
|
|
@darktears manamana |
|
YEah.... |
rakuco
pushed a commit
that referenced
this pull request
Jul 28, 2014
[Temp] Roll ANGLE to 5ac2ae3ea1f311be61955b2d554e8510474cf4f0.
darktears
pushed a commit
that referenced
this pull request
Sep 17, 2014
…e size. The problem is that some locales (Hindi) or platforms (Linux) have a bigger base font size for the default font (crbug.com/405994). If this is the case, we should decrease the font size to the one we expect, so that the font fits in the button correctly. Just adjusting the baseline is not always enough, as the new avatar button has a fixed size, and the text might not fit correctly regardless of the baseline adjustments. Screenshots: https://drive.google.com/folderview?id=0B1B1Up4p2NRMRHc5WTBxZWNrRm8&usp=sharing BUG=403466 TBR=noms@chromium.org TEST=Start Chrome with --enable-new-avatar-menu on Linux, or with --enable-new-avatar-menu and --lang-hi on Windows. The avatar button text should fit nicely in the button. Review URL: https://codereview.chromium.org/470053004 Cr-Commit-Position: refs/heads/master@{#292715} (cherry picked from commit 899ae44) Review URL: https://codereview.chromium.org/534713002 Cr-Commit-Position: refs/branch-heads/2125@{#181} Cr-Branched-From: b68026d-refs/heads/master@{#290040}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
> The CL causes crashes. > > > This fixes a bug with notifications getting stucked on screen while > > hovering with mouse old notifications popups and new arrived popups. > > Source of the problem is popup animation getting stopped, rather when > > finished. > > > > BUG=418053 > > R=jianli@chromium.org, thakis@chromium.org > > > > TEST=see http://crbug.com/418053 for reproduction details. > > > > Committed: https://crrev.com/39caad968f9b43d7b24d6c2d75596161a951de68 > > Cr-Commit-Position: refs/heads/master@{#298805} > > BUG=423001 > > Review URL: https://codereview.chromium.org/856633002 > > Cr-Commit-Position: refs/heads/master@{#312290} BUG=423001 TBR=avi@chromium.org Review URL: https://codereview.chromium.org/865133003 Cr-Commit-Position: refs/branch-heads/2272@{#181} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
…), such as when zoomed in at specific zoom levels on network error interstitial. + Improve overflow content scrolling, remove the internal scroll. + Increase bottom margin of content area to fix cut off content. + Allow the anchored fixed nav from 240px + Remove button height and fix issue where the buttons stick together BUG=463838,463070 Review URL: https://codereview.chromium.org/979243002 (cherry picked from commit 5b0ae92) Cr-Original-Commit-Position: refs/heads/master@{#319433} Cr-Commit-Position: refs/branch-heads/2311@{#181} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Apr 28, 2015
Use the kernel notifier (/dev/chromeos-low-mem) to detect low memory. Change kNormalMemoryPressureCriticalThresholdPercent to 95 to match the kernel's threshold. FIxed windows dependency from hashimoto's patchset patch from issue 1093123002 at patchset 40001 (http://crrev.com/1093123002#ps40001) BUG=1093123002 TBR=hashimoto@chromium.org Review URL: https://codereview.chromium.org/1068963003 Cr-Commit-Position: refs/heads/master@{#325868} (cherry picked from commit fc49377) Review URL: https://codereview.chromium.org/1058433005 Cr-Commit-Position: refs/branch-heads/2357@{#181} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
Add check that the web view's URL is still the expected URL in callback from JavaScript in webViewURLDidChange. As this call is asynchronous, the user may have already navigated away from the expected URL by the time the callback is reached. BUG=560507, 563568 Review URL: https://codereview.chromium.org/1472733003 Cr-Commit-Position: refs/heads/master@{#362287} (cherry picked from commit ad3f670) Review URL: https://codereview.chromium.org/1492483002 . Cr-Commit-Position: refs/branch-heads/2564@{#181} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
R=piman@chromium.org BUG=579721, 514815 Review URL: https://codereview.chromium.org/1608313003 Cr-Commit-Position: refs/heads/master@{#370600} (cherry picked from commit 03839e2) Review URL: https://codereview.chromium.org/1644163003 . Cr-Commit-Position: refs/branch-heads/2623@{#181} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
The positioning of windows is not predictable when running tests, and some tests can end up having their renderer processes backgrounded due to occlusion, causing unpredictable behavior. Disable occlusion API use when running tests. Occlusion is a Mac-only API for the moment, but leave this as non-Mac so that it can be picked up if needed. Also, get rid of the "we're on 10.9+" check. We always are now. BUG=558585 Review URL: https://codereview.chromium.org/1762883002 Cr-Commit-Position: refs/heads/master@{#379500} (cherry picked from commit 19b720a) Review URL: https://codereview.chromium.org/1782153002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#181} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#181}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
For now we don't want to tie the toggle button with pref value, but tie it with the actual bluetooth power state. The next CL will add the preference saving when bluetooth power toggle is completed. BUG=741962 TBR=sonnysasaka@chromium.org (cherry picked from commit 2f12172) Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I694da134690241b7953f66ccebc9e6a34451a03a Reviewed-on: https://chromium-review.googlesource.com/646756 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499105} Reviewed-on: https://chromium-review.googlesource.com/664177 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#181} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually advance the ANGLE checkout one commit ahead in its
chromium/2062 to grab the fix its bug 669 ("Build started depending on
.git/").
This is required for a build from a tarball to work, and allows us to
remove our manual workaround from the Tizen packaging.
The roll upstream will be part of more recent M37 releases.