This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 211
[Temp] Fix ANGLE's hash after ab6d5f16. #182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I read https://chromium.googlesource.com/angle/angle/+/chromium/2062 wrong and used the "tree" hash instead of the actual commit hash. Big pointy hat to me.
Testing patch series with 7fe3516 as its head.
|
ok |
rakuco
pushed a commit
that referenced
this pull request
Jul 28, 2014
[Temp] Fix ANGLE's hash after ab6d5f1.
darktears
pushed a commit
that referenced
this pull request
Sep 17, 2014
Fix bug in QuicHttpStream::SendRequest. If the session is closed before SendRequest is called, a CHECK would fire in SendRequest(). BUG=409101 TBR=amineer Review URL: https://codereview.chromium.org/523463007 Cr-Commit-Position: refs/heads/master@{#292775} (cherry picked from commit f9f103c) Review URL: https://codereview.chromium.org/531903002 Cr-Commit-Position: refs/branch-heads/2125@{#182} Cr-Branched-From: b68026d-refs/heads/master@{#290040}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
Removes "ui-sans" from the ChromeOS system UI default font list. The ChromeOS system UI (rendered through HarfBuzz) now relies on gfx::RenderText::CreateSkiaTypeface(), and skia actually returns exactly same typeface for 'Noto Sans UI' and 'ui-sans' in the current configuration. ui-sans is simply redundant. BUG=444894 TBR=jshin@chromium.org Review URL: https://codereview.chromium.org/823003002 Cr-Commit-Position: refs/heads/master@{#313189} (cherry picked from commit 550404a) Review URL: https://codereview.chromium.org/890913004 Cr-Commit-Position: refs/branch-heads/2272@{#182} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
And re-enable ExtensionApiTest.WindowOpen, to verify that the new test is effective. This test was introduced by crbug.com/52298, but disabled by crbug.com/64899. The test is supposed to check whether a tab that is opened via window.open() from an extension process associated with a particular Browser is opened in a non-incognito browser when 'incognito' is not set to 'split' (but the default, 'spanning'). BUG=458325,64899 R=rdevlin.cronin@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/942873003 Cr-Commit-Position: refs/heads/master@{#317509} (cherry picked from commit f8cd8ce) Review URL: https://codereview.chromium.org/988303004 Cr-Commit-Position: refs/branch-heads/2311@{#182} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Apr 28, 2015
"Merge apps and tabs" feature promotion is moving to the new tab page so it is no longer needed in first run. BUG=467437 TBR=aruslan@chromium.org Review URL: https://codereview.chromium.org/1071303003 Cr-Commit-Position: refs/heads/master@{#325343} Review URL: https://codereview.chromium.org/1060633005 Cr-Commit-Position: refs/branch-heads/2357@{#182} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
The blacklisting forms aren't scored. They are just matched against the current form. The password save bubble should contain 'x' as specified by the UI review. BUG=493257 TBR=groby@chromium.org,vabr@chromium.org Review URL: https://codereview.chromium.org/1322823002 Cr-Commit-Position: refs/heads/master@{#346663} (cherry picked from commit 3a24dad) Review URL: https://codereview.chromium.org/1311013011 . Cr-Commit-Position: refs/branch-heads/2490@{#182} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
…oaded .zip's For zips that failed to parse completely, send a ping if we see an exe/zip in it or if the user is in safe browsing extended-reporting. BUG=53595 Review URL: https://codereview.chromium.org/1441243002 Cr-Commit-Position: refs/heads/master@{#361410} (cherry picked from commit 74fbd56) Review URL: https://codereview.chromium.org/1489573004 . Cr-Commit-Position: refs/branch-heads/2564@{#182} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
BUG=586852 TEST=FrameViewTest.HideTooltipWhenScrollPositionChanges Review URL: https://codereview.chromium.org/1735363003 Cr-Commit-Position: refs/heads/master@{#378446} (cherry picked from commit 933d8eb) Review URL: https://codereview.chromium.org/1782163002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#182} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
InputMethodManagerService in Android platform sometimes access disk to record the IME state. This prevents crashes in dev. BUG=616283 Review-Url: https://codereview.chromium.org/2027923002 Cr-Commit-Position: refs/heads/master@{#397224} (cherry picked from commit 9cde65f) Review URL: https://codereview.chromium.org/2032873002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#182} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
Note: This is a reland of http://crrev.com/6e30800 with the fix for the test breakage. BUG=741962 TBR=sonnysasaka@chromium.org (cherry picked from commit 1acacb7) Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iec33e451a6068bf03a6871570c4b2c66919887af Reviewed-on: https://chromium-review.googlesource.com/651268 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499798} Reviewed-on: https://chromium-review.googlesource.com/663790 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#182} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read https://chromium.googlesource.com/angle/angle/+/chromium/2062
wrong and used the "tree" hash instead of the actual commit hash.
Big pointy hat to me.