This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
M38 [Tizen][Temp] Move ScreenOrientationProvider::Create to cc file #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rakuco PTAL |
|
OK, I'll merge this temporarily to get Tizen to build again. |
rakuco
pushed a commit
that referenced
this pull request
Aug 29, 2014
M38 [Tizen][Temp] Move ScreenOrientationProvider::Create to cc file
This commit fixes ScreenOrientationProvider::Create() to be defined multiple times error. Meanwhile, add ScreenOrientationDispatcherHost::SetProvider so that tizen can use this inferface to bridge with ScreenOrientationDispatcherHost. Upstream bug https://code.google.com/p/chromium/issues/detail?id=408573 to trace this problem. Send https://codereview.chromium.org/513073002/ to solve it. CL: https://codereview.chromium.org/338373002
darktears
pushed a commit
that referenced
this pull request
Nov 17, 2014
This CL fixes a regression introduced by crrev.com/293777. InstallVerifier::AllowedByEnterprisePolicy() are intended to query the policy system whether an extension are explicitly allowed by enterprise or not. But crrev.com/293777 changed the behavior into querying it's allowed to install or not, which in most cases, are true. But the ExtensionMetricsProvider considers every extension explicitly allowed by enterprise policy as from webstore, thus every off-store extensions are marked as from webstore in metrics. Fix the regression by restoring into the original behavior. BUG=423705 Review URL: https://codereview.chromium.org/651253003 Cr-Commit-Position: refs/heads/master@{#299694} (cherry picked from commit c641add) Conflicts: chrome/browser/extensions/extension_management.cc chrome/browser/extensions/extension_management.h Review URL: https://codereview.chromium.org/663063002 Cr-Commit-Position: refs/branch-heads/2171@{#185} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
Previously if we got an invalid event stream such as Press id 0 Press id 0 MotionEventAura would happily add the second pointer. Now we replace the first pointer with the second pointer. This work around is required due to crbug.com/373125. BUG=450880 Review URL: https://codereview.chromium.org/873283003 Cr-Commit-Position: refs/heads/master@{#313116} (cherry picked from commit b88d572) Review URL: https://codereview.chromium.org/867823005 Cr-Commit-Position: refs/branch-heads/2272@{#185} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
…tps://codereview.chromium.org/939443002/) that added a conversion from logical to physical units to fix a similar sizing bug with other guestviews. However, MIME handler guests never use logical pixels, so this conversion broke their sizing when they are created in a zoomed embedder. This patch adds a more robust method of checking whether sizes are provided in logical or physical units, and all cases are handled appropriately. BUG=462194 Review URL: https://codereview.chromium.org/972193003 (cherry picked from commit 18f5a13) Cr-Original-Commit-Position: refs/heads/master@{#318948} Cr-Commit-Position: refs/branch-heads/2311@{#185} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Apr 28, 2015
This is important when re-building a focus grid so that any previously focused row is now unfocused. BUG=473071 NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1052263002 Cr-Commit-Position: refs/heads/master@{#325137} (cherry picked from commit 9ac0f44) Review URL: https://codereview.chromium.org/1099173002 Cr-Commit-Position: refs/branch-heads/2357@{#185} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
…rywhere Fix a regression where whitelisted extensions couldn't inject content scripts on other extension pages. BUG=517370 TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/1294393003 Cr-Commit-Position: refs/heads/master@{#345382} (cherry picked from commit 29d2ec9) Review URL: https://codereview.chromium.org/1319143004 . Cr-Commit-Position: refs/branch-heads/2490@{#185} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
…en user tries to recover blocked downloads BUG=515313 Review URL: https://codereview.chromium.org/1436273002 Cr-Commit-Position: refs/heads/master@{#361816} (cherry picked from commit 7f11b74) Review URL: https://codereview.chromium.org/1489133002 . Cr-Commit-Position: refs/branch-heads/2564@{#185} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
…rted Still detect the situation when the app is creating WebView from two processes sharing the same data dir, but do not throw a RuntimeError, only print a warning. BUG=558377,582146 Review URL: https://codereview.chromium.org/1641383002 Cr-Commit-Position: refs/heads/master@{#372231} (cherry picked from commit d881bd2) Review URL: https://codereview.chromium.org/1650433003 . Cr-Commit-Position: refs/branch-heads/2623@{#185} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
…actions Extensions with synthesized actions shouldn't get the "How to use" text. BUG=592106 Review URL: https://codereview.chromium.org/1778603003 Cr-Commit-Position: refs/heads/master@{#380161} (cherry picked from commit 0a95746) Review URL: https://codereview.chromium.org/1779343002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#185} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
…ally This patch removes the call-time check for origin-trial-enabled features, replacing it with code that installs features into the V8 context as trial tokens are encountered. This means that experimental features which were previously polluting the global namespaces are now completely unavailable except when enabled by origin trials. (The specific case of pollution caused by Durable Storage is removed from test expectations in this patch) Origin trials are now initialized after the V8 context, by calling initializeOriginTrials. This calls, through a series of function pointers, the bindings initialization code for core, modules, and optionally internals (for tests). This patch implements the design at https://docs.google.com/document/d/1vwKD8sUrr5mtktvEwvO_f2KUsNhpcgLMixYXhD8K4KY BUG=584367 Review-Url: https://codereview.chromium.org/2005433002 Cr-Commit-Position: refs/heads/master@{#396860} (cherry picked from commit e3f3c54) Review URL: https://codereview.chromium.org/2032613005 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#185} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
Due to http://b/64035404, sometimes bluetooth adapter loses USB connectivity and this triggers null pointer dereference in Chrome. This CL guards the null pointer and return error instead to prevent Chrome from crashing. BUG=757893 TEST=Integration test: Simulate bluetooth adapter losing USB connectivity by running "rmmod btusb", then use a chrome app to call chrome.bluetoothLowEnergy.* advertisement-related methods and check that Chrome doesn't crash but displays errors instead. TBR=sonnysasaka@chromium.org (cherry picked from commit be0c16a) Change-Id: Ib5bee9f6bbb5eca2b61b713841803d1c2ca5ac0f Reviewed-on: https://chromium-review.googlesource.com/636343 Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499314} Reviewed-on: https://chromium-review.googlesource.com/664088 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#185} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes ScreenOrientationProvider::Create() to be defined multiple
times error. Meanwhile, add ScreenOrientationDispatcherHost::SetProvider so that
tizen can use this inferface to bridge with ScreenOrientationDispatcherHost.
Upstream bug https://code.google.com/p/chromium/issues/detail?id=408573 to trace this problem.
Send https://codereview.chromium.org/513073002/ to solve it.
CL: https://codereview.chromium.org/338373002