Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

[Android]Include khronos's OpenCL header file to support WebCL. #188

Closed
wants to merge 1 commit into from
Closed

[Android]Include khronos's OpenCL header file to support WebCL. #188

wants to merge 1 commit into from

Conversation

junmin-zhu
Copy link
Contributor

These OpenCL files come from khronos, which is the MIT license.
Its version is OpenCL 1.2, which is the latest version supported
on Android platform.

BUG=XWALK-2359

@junmin-zhu
[Android]Include khronos's OpenCL header file to support WebCL.
039df5a 
These OpenCL files come from khronos, which is the MIT license.
Its version is OpenCL 1.2, which is the latest version supported
on Android platform.
@crosswalk-trybot
Copy link

Testing patch series with junmin-zhu/chromium-crosswalk@039df5a as its head.

Bot Status
Content Shell Linux [FAILED 💔](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/115)
Content Shell Android-x86 [FAILED 💔](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/114)

@junmin-zhu
Copy link
Contributor Author

@kenchris @wang16 @sqliu , please help to review the patch, thanks.

@wang16
Copy link

wang16 commented Sep 15, 2014

Is it possible to be a repo in gclient?

@junmin-zhu
Copy link
Contributor Author

@wang16 , you mean create a new repo for these headers?

@rakuco
Copy link

rakuco commented Sep 15, 2014

That is a lot of code with no reference to a JIRA ticket or mailing list discussion, nor an explanation as to why it is needed and what Chromium's position is about this.

@junmin-zhu
Copy link
Contributor Author

This is a dependent patch for webcl support in Chromium repo.

There is a design doc for WebCL, which is available at https://docs.google.com/a/intel.com/document/d/1fl5cGCFW1PDqtq0zDoiVnQ
05dwyNYxtjmb4GdapiX7c/edit. and there is also a intent to implement in mailing list named "Khronos WebCL API for Android.", and got +3 for implementation.

The jira ticket is https://crosswalk-project.org/jira/browse/XWALK-2359.

@junmin-zhu
Copy link
Contributor Author

@wang16 , these header files are hosted on official wiki of khronos (http://www.khronos.org/registry/cl/), not in the separate git/subversion repo. If we want to include it as a repo, I think we have to create a repo for them.

@rakuco
Copy link

rakuco commented Sep 15, 2014

This is a dependent patch for webcl support in Chromium repo.

There is a design doc for WebCL, which is available at https://docs.google.com/a/intel.com/document/d/1fl5cGCFW1PDqtq0zDoiVnQ05dwyNYxtjmb4GdapiX7c/edit. and there is also a intent to implement in mailing list named "Khronos WebCL API for Android.", and got +3 for implementation.

The jira ticket is https://crosswalk-project.org/jira/browse/XWALK-2359.

As I've said time and again, this information is supposed to be in the pull request and commit messages, explaining things in a comment does not make it better. Think of all the people in the future (including non-Intel ones who may not be able to access your design document) who will look at this commit and have no clue about what is going on and why it is needed.

Additionally, there's one unanswered question: what is Chromium's position with this? Will these be upstreamed or are we bound to carry these headers forever?

@junmin-zhu
Copy link
Contributor Author

@rakuco, thanks for your reminder. Will follow the instruction.

Chromium has no plan for WebCL, so it will not be accepted by upstream in short term.

After discuss with @wang16 , we will add its subversion repo to DEPS for these headers. And submit a new PR in Crosswalk repo (crosswalk-project/crosswalk#2426). So close this PR.

Thanks.

@junmin-zhu junmin-zhu closed this Sep 16, 2014
darktears pushed a commit that referenced this pull request Sep 17, 2014
@stevenjb
Fix GSM in Setings
725b744 
This fixes a bug introduced in https://codereview.chromium.org/427903004

BUG=406114
TBR=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/492373002

Cr-Commit-Position: refs/heads/master@{#291415}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291415 0039d316-1c4b-4281-b951-d872f2087c98
(cherry picked from commit 8e0e343)

Review URL: https://codereview.chromium.org/533933004

Cr-Commit-Position: refs/branch-heads/2125@{#188}
Cr-Branched-From: b68026d-refs/heads/master@{#290040}
darktears pushed a commit that referenced this pull request Nov 17, 2014
@reillyeon
Merge b321e4f and e8fa00e into M-39 branch (issue 418207).
eab0388 
Use IOService enumeration instead of IOHIDManager in HidServiceMac.

Using the IOServiceAddMatchingNotification API to monitor devices
connected to the system is preferable to IOHIDManager because it is
lighter weight. IOHIDManager forces its own lifetime expectations on
the IOHIDDevice objects that it creates and opens all devices it sees
for I/O whether or not there is a Chrome app that is using them.

As a necessary step to simplify this transition the device/hid API now
lives on the browser UI thread when running on OS X. This change will
soon be made for Linux and Windows as well. This change should also
reduce the risk of race conditions as observed in bug 418207 which is
why it is being made independently of the other platforms.

BUG=418207,413978
R=rockot@chromium.org, rpaquay@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/637863003

Cr-Commit-Position: refs/heads/master@{#298793}

Conflicts:
	extensions/browser/api/hid/hid_api.cc

Add HidConnection::Close and register OS X callbacks on the UI thread.

The platform implementation of a HID connection may need to cancel I/O
operations when the connection is closed. If this is done during the
object destructor then any pointers held by those pending operations are
immediately invalid. A separate Close method allows the cleanup to
happen while the object is still available to handle asynchronous
cancellation events.

The OS X implementation will take advantage of this immediately to
register and unregister its input report callback from the UI thread to
avoid a race between event delivery and object cleanup. I've added
comments explaining why not all operations on the IOHIDDevice object
could be moved to the UI thread.

BUG=418207

Review URL: https://codereview.chromium.org/615633008

Cr-Commit-Position: refs/heads/master@{#298384}

Conflicts:
	device/hid/hid_connection_linux.h
	device/hid/hid_connection_mac.h
	device/hid/hid_connection_win.h

Review URL: https://codereview.chromium.org/648613002

Cr-Commit-Position: refs/branch-heads/2171@{#188}
Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco pushed a commit that referenced this pull request Feb 27, 2015
@kkimdev
[Android] Change enhanced bookmark folder structure.
dc6f13b 
- Top level folders are now all the sub folders of
  Bookmark Bar, Mobile, and Others nodes.
- We no longer use Uncategorized.

BUG=453024

Review URL: https://codereview.chromium.org/869193008

Cr-Commit-Position: refs/heads/master@{#314013}
(cherry picked from commit a01c664)

TBR=newt@chromium.org

Review URL: https://codereview.chromium.org/894853002

Cr-Commit-Position: refs/branch-heads/2272@{#188}
Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco pushed a commit that referenced this pull request Mar 12, 2015
Fix CapsLock remapping.
ef7fdad 
Emulates the ChromeOS/X11 method of using F16 and Mod3 to
represent the caps lock key before remapping.

BUG=461485
TEST=On device with external keyboard
TBR=spang

Review URL: https://codereview.chromium.org/959923002

Cr-Commit-Position: refs/heads/master@{#318321}
(cherry picked from commit c786931)

Review URL: https://codereview.chromium.org/995563002

Cr-Commit-Position: refs/branch-heads/2311@{#188}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco pushed a commit that referenced this pull request Apr 30, 2015
QUIC - fix packet loss rate calculation (use float).
a9606a0 
BUG=478956
TBR=rch@chromium.org

Review URL: https://codereview.chromium.org/1100633002

Cr-Commit-Position: refs/heads/master@{#325958}
(cherry picked from commit f5d7ecd)

Review URL: https://codereview.chromium.org/1100043002

Cr-Commit-Position: refs/branch-heads/2357@{#188}
Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk pushed a commit that referenced this pull request Sep 22, 2015
[Custom tab]Fix a bug that clicking media notification opens blank tab
ebe8544 
This CL lets Tab#createBringTabToFrontIntent() return null if the given
tab id belongs to a custom tab. A "clickable" notion is introduced here
to describe notifications that do not carry a content intent.

BUG=524855

Review URL: https://codereview.chromium.org/1328663003
Cr-Commit-Position: refs/heads/master@{#347768}
TBR=dfalcantara@chromium.org

Review URL: https://codereview.chromium.org/1323263008 .

Cr-Commit-Position: refs/branch-heads/2490@{#188}
Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk pushed a commit that referenced this pull request Dec 18, 2015
@erikchen
Merge "Fix a bug in the implementation of Mach shared memory." to M48.
f364a5d 
> The bug prevented Mach shared memory from being mapped, after being unmapped.
>
> BUG=466437
>
> Review URL: https://codereview.chromium.org/1452063003
>
> Cr-Commit-Position: refs/heads/master@{#360192}

(cherry picked from commit 8d84ed5)
TBR=mark@chromium.org
BUG=563762

Review URL: https://codereview.chromium.org/1487203002 .

Cr-Commit-Position: refs/branch-heads/2564@{#188}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco pushed a commit that referenced this pull request Mar 3, 2016
@cbiesinger
[css-flexbox] Use correct aspect ratio for min-size: auto
3096d15 
https://codereview.chromium.org/1421423005 caused this regression. We never
handled aspect ratio correctly in flexbox (that's bug 249112), but that patch
made our handling worse because we now distort and enlarge images when
a cross axis size is specified that's bigger than the image's intrinsic size.

This was tested by
imported/csswg-test/css-flexbox-1/flex-minimum-height-flex-items-008.xht which
we now pass. I didn't realize the significance of failing that test at the time :(

BUG=581361,581535
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1639723003

Cr-Commit-Position: refs/heads/master@{#372000}
(cherry picked from commit eba8fa2)

Review URL: https://codereview.chromium.org/1643123002 .

Cr-Commit-Position: refs/branch-heads/2623@{#188}
Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request May 17, 2016
Incrementing VERSION to 50.0.2661.27
5171c41 
Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#188}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request Oct 9, 2016
@galmacky
Change ThreadedInputConnection to extend BaseInputConnection
1eb5b9b 
There is an email client app that tries to cast ThreadedInputConnection
to BaseInputConnection. It is their fault, but we do not want to cause
crashes when ImeThread feature gets launched, so here is a workaround.

BUG=616334

Review-Url: https://codereview.chromium.org/2025173003
Cr-Commit-Position: refs/heads/master@{#397302}
(cherry picked from commit 6e6702b)

Review URL: https://codereview.chromium.org/2030863002 .

Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#188}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
@JinsukKim
Fix a bug in disambiguation popup
6a20a7a 
The reported bug was caused by http://crrev.com/497292 that
refactors the popup zoomer used for tap disambiguation. This CL
fixes it by scaling the touch event coordinate correctly before
sending it to Blink.

Bug: 763553
Change-Id: Ib0ab717daaf21018ed16c88a5fb3b69a768156a6
Reviewed-on: https://chromium-review.googlesource.com/658203
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501069}(cherry picked from commit aa2555e)
Reviewed-on: https://chromium-review.googlesource.com/664317
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#188}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@junmin-zhu @crosswalk-trybot @wang16 @rakuco